Repository navigation
test(rttrpm): keep the packet-splitting markers off the wall clock - #497
Merged
Merged
Conversation
The packet-splitting tests built their markers on the real clock and sent them through the RTTrPM server, which withholds a trackable unwritten for a second. On a loaded test Pi, building the markers took longer than that, so the early ones were withheld and the count assertions failed (two gates failed this way: 12 of 14 and 137 of 299 withheld). The shared marker factory and the renaming marker now stamp from one frozen instant, so no marker can age during a test. The stale-marker test keeps the real clock on purpose. With every marker clock read jumping 2 s, 16 RTTrPM tests failed before and none fail now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The packet-splitting tests built their markers on the real clock and sent them through the RTTrPM server, which withholds a trackable that has not been written for a second. On a loaded test Pi, building the markers took longer than that. The early markers were withheld and the count assertions failed: two
make ci-remotegates today failed this way, with 12 of 14 and 137 of 299 trackables withheld.The fix: the shared marker factory and the renaming marker now stamp from one frozen instant, so no marker can age during a test. The stale-marker test keeps the real clock on purpose.
Test plan
make ci-remoteon the testing Pi.🤖 Generated with Claude Code