chore: add release type and package name to config#267
chore: add release type and package name to config#267SoulPancake wants to merge 2 commits intomainfrom
Conversation
WalkthroughThe release-please configuration for the root package is updated to explicitly set Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #267 +/- ##
=======================================
Coverage 69.84% 69.84%
=======================================
Files 140 140
Lines 10743 10743
=======================================
Hits 7503 7503
Misses 3240 3240 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
Updates the repository’s release-please configuration to better align Conventional Commit grouping with this repo’s release workflow and to explicitly set package metadata for the root package.
Changes:
- Add a
package-namefield under the rootpackages["."]configuration. - Add a
releaseConventional Commit type tochangelog-sections(hidden).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@release-please-config.json`:
- Around line 21-22: Remove the dead mapping for the "release" conventional
commit type from the release-please configuration by deleting the JSON entry
with "type": "release" (the object { "type": "release", "section":
"Miscellaneous", "hidden": true }). Ensure only the unused mapping is removed
and the surrounding JSON array remains valid (comma placement adjusted if
needed).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: b635caa0-a064-4b00-b670-c5018074d890
📒 Files selected for processing (1)
release-please-config.json
| { "type": "chore", "section": "Miscellaneous", "hidden": true }, | ||
| { "type": "release", "section": "Miscellaneous", "hidden": true } |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
echo "== Recent commit subjects using release: type =="
git log --pretty=format:%s -n 500 | rg -n '^release(\([^)]+\))?:\s' || true
echo
echo "== Commitlint/conventional-commit config references (if present) =="
rg -n --iglob '*commitlint*' --iglob '*.js' --iglob '*.cjs' --iglob '*.json' 'type-enum|release'Repository: openfga/python-sdk
Length of output: 472
Remove the unused release type mapping on line 22.
The repository's last 500 commits contain no release: conventional commit types, and no commitlint configuration defines this type. This changelog mapping is dead config and can be removed for clarity.
Verification
== Recent commit subjects using release: type ==
(no matches found in last 500 commits)
== Commitlint/conventional-commit config references ==
release-please-config.json:22: { "type": "release", "section": "Miscellaneous", "hidden": true }
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@release-please-config.json` around lines 21 - 22, Remove the dead mapping for
the "release" conventional commit type from the release-please configuration by
deleting the JSON entry with "type": "release" (the object { "type": "release",
"section": "Miscellaneous", "hidden": true }). Ensure only the unused mapping is
removed and the surrounding JSON array remains valid (comma placement adjusted
if needed).
Description
What problem is being solved?
How is it being solved?
What changes are made to solve it?
References
Review Checklist
mainSummary by CodeRabbit