Skip to content

chore: add .editorconfig and .gitattributes#1049

Open
srpatcha wants to merge 1 commit into
openembedded:masterfrom
srpatcha:chore/add-editorconfig-gitattributes
Open

chore: add .editorconfig and .gitattributes#1049
srpatcha wants to merge 1 commit into
openembedded:masterfrom
srpatcha:chore/add-editorconfig-gitattributes

Conversation

@srpatcha
Copy link
Copy Markdown

Changes

chore: add .editorconfig and .gitattributes

Add editor configuration and line ending normalization
for consistent development across platforms.

Signed with GPG.

Comment thread .editorconfig
Comment thread .editorconfig
Comment thread .editorconfig Outdated
Comment thread .gitattributes Outdated
Comment thread scripts/lint_recipes.py Outdated
Comment thread meta-oe/recipes-benchmark/linpack/linpack_1.0.bb Outdated
@srpatcha srpatcha force-pushed the chore/add-editorconfig-gitattributes branch from b7a6c09 to dd7ab8f Compare May 5, 2026 01:56
@srpatcha
Copy link
Copy Markdown
Author

srpatcha commented May 5, 2026

Hi @petermarko, thank you for the detailed review! I've addressed all three points:

  1. ✅ **Moved \indent_size\ and \indent_style = space\ to []* as defaults
  2. Added [*.{patch,diff}]\ section that explicitly unsets every property to avoid touching patch/diff files
  3. ✅ **Removed [.{yml,yaml}]* since there are no YAML files in the repo
  4. Also dropped the unrelated recipe-lint commit per the focused-PR principle

The branch has been force-pushed. Ready for re-review!

@petermarko
Copy link
Copy Markdown
Contributor

The branch has been force-pushed. Ready for re-review!

changes in .editorconfig LGTM, but I don't have rights to resove the conversations.

the .gitattributes comment was not answered yet...

Add editor configuration and line ending normalization
for consistent development across platforms.

Signed-off-by: Srikanth Patchava <srpatcha@users.noreply.github.com>
@srpatcha srpatcha force-pushed the chore/add-editorconfig-gitattributes branch from dd7ab8f to 7be846e Compare May 6, 2026 04:56
@srpatcha
Copy link
Copy Markdown
Author

srpatcha commented May 6, 2026

Hi @petermarko, addressed your .gitattributes feedback! Surveyed actual file contents in the repo and rewrote the file to only cover what's there:

Removed (suffixes not present in repo): csv, yml, yaml, html, css, jpg, jpeg, gif, ico, pdf, gz, tar

Added (the bulk of the repo, ~5,000 BitBake files): bb (2,448), bbappend (5), bbclass (28), inc (80), conf (74), cfg (7)

Kept (actually present): md (21), txt (21), json (1), xml (1), png (2), zip (1)

Added explicit -text for *.patch (2,409 files) and *.diff (14 files) so git doesn't normalize line endings — matches the unset behavior in the new .editorconfig.

Force-pushed. Both files should now be appropriate for the repo. Ready for re-review!

@srpatcha
Copy link
Copy Markdown
Author

srpatcha commented May 6, 2026

Hi @OldManYellsAtCloud, thank you for the detailed review on the lint script and linpack recipe! Per the focused-PR feedback from @petermarko, I dropped both scripts/lint_recipes.py and the linpack HOMEPAGE change in the restructure. The current PR scope is now only .editorconfig + .gitattributes (verified via gh pr diff --name-only shows just those two files). The recipe-lint tool is a separate concern and I'll re-evaluate against the existing oe-core QA checks before submitting it as its own PR. Thanks for the helpful pointers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants