Version packages - #209
Version packages#209leoisadev1 wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThe release remains blocked because the SDK is versioned as 2.0.0 while the active documentation configuration still tracks the v1 line. The required documentation-version validation rejects this mismatch, so release CI and package publication cannot complete. Confidence Score: 4/5Not safe to merge for release: the unresolved documentation-version mismatch prevents the required release checks from passing. The outstanding previous finding remains unresolved. Reviews (13): Last reviewed commit: "Version packages" | Re-trigger Greptile |
49090d7 to
f1e37f3
Compare
f1e37f3 to
5d639cf
Compare
5d639cf to
03db2b9
Compare
03db2b9 to
4a5b35a
Compare
4a5b35a to
f54d999
Compare
f54d999 to
2b01a28
Compare
2b01a28 to
6bfbb5a
Compare
6bfbb5a to
1401281
Compare
1401281 to
35d883b
Compare
| { | ||
| "name": "@opencoredev/email-sdk", | ||
| "version": "1.2.0", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
🔴 SMTP replacement missing from release
Installing 2.0.0 leaves smtp on the hand-rolled transport and rejects attachments before connecting. smtp still uses SmtpClient, and the manifest has no Nodemailer dependency.
Learn more
This release consumes the major changeset and publishes the package as 2.0.0. However, the packaged smtp implementation still constructs the hand-written SmtpClient, while its capabilities reject attachments. The package manifest also declares no Nodemailer runtime dependency. The added changelog therefore describes code that the 2.0.0 tarball does not contain.
Example: A consumer upgrades to 2.0.0 and sends { attachments: [{ filename: "invoice.pdf", content: data }] } through smtp. The advertised release accepts and MIME-encodes the attachment, but this package fails validation before opening the SMTP connection.
Recommended fix: Land the Nodemailer-backed SMTP implementation, dependency, capability changes, and tests before versioning. Otherwise remove the unimplemented claims and reconsider the major bump before publishing.
Was this helpful? React with 👍 or 👎 to provide feedback.
| { | ||
| "name": "@opencoredev/email-sdk", | ||
| "version": "1.2.0", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
| { | ||
| "name": "@opencoredev/email-sdk", | ||
| "version": "1.2.0", | ||
| "version": "2.0.0", |
There was a problem hiding this comment.
This release changes the SDK to 2.0.0, but the active documentation configuration still tracks v1. The required documentation-version check rejects that mismatch, so release CI cannot complete and the package cannot be published until the v2 documentation configuration is updated or the v1 line is archived.
Artifacts
- Compared the supplied SHA with the candidate package and showed the actual package version transition is 1.3.0 to 2.0.0, confirming the supplied SHA does not contain 1.2.0.
Documentation-version gate harness
- Authored and executed this shell harness to run the identical repository gate for the prior SHA’s real package version and the current candidate without modifying repository source, preserving comparable output.
- Ran the docs-version gate with its supported package-version simulation set to the supplied SHA’s actual 1.3.0 version; it did not report the v2-versus-v1 current-track mismatch.
- Ran the repository docs-version gate against current package metadata and captured its exit-1 major/docs-track error, confirming the candidate is blocked specifically by 2.0.0 exceeding v1.
35d883b to
b6ad727
Compare
b6ad727 to
38bd751
Compare
38bd751 to
7d6c014
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@opencoredev/convex-email@4.0.0
Major Changes
exposeApi()with authenticated ownership checks. Unauthenticated callers can no longer send, read, cancel, or retry email records; useauthorizefor custom tenant or operation policy, andauthorizeConfigfor explicitly authorized configuration access.Patch Changes
@opencoredev/email-sdk@2.0.0
Major Changes
telemetry: false,EMAIL_SDK_TELEMETRY=0, andDO_NOT_TRACK=1opt-outs; events use a stable installation identifier and never include message content, addresses, or credentials. Move repository CI workflows to Tenki Cloud runners and add Node 20/22/24 package-compatibility coverage.Minor Changes
doctor --live,--from, and--jsondiagnostics with independently reportedconfiguration,authentication, andsenderchecks. Defaultdoctorstays configuration-only and makes no network request. Live probes use documented non-sending endpoints for Resend, Sequenzy, JetEmail, Primitive, Lettermint, and Lettr; Resend additionally supports paginated sender-domain readiness via--from, while other adapters report sender readiness asunsupported. Results distinguishinvalid_credentials,insufficient_permissions,inconclusive,rate_limited,network_failure,timeout,unsupported, andnot_ready; generic HTTP 400/422 responses are never treated as authentication success. Probes are bounded by a timeout, reject redirects and non-loopback base URL overrides, and never print credentials, response bodies, or account identifiers. The live verification scripts reuse the same probes.^20.19.0 || >=22.12.0(20.19+ on 20.x, or 22.12+) to load every SDK entry point withrequire(). ESM imports still support Node.js 20+. Typed CommonJS consumers need TypeScript 5.8+ withmodule: nodenext, or a compiler supportingmodule: node20. On older supported runtimes, use dynamicimport()instead.Patch Changes
delivered_countmetric, exclude built-in test adapters from provider volume even when renamed, and preserve acceptance evidence when later middleware fails. Default-on telemetry and existing opt-outs remain unchanged. Document aggregation rules and why provider acceptance does not establish delivery.