fix(editors): open remote projects in Zed - #221
Merged
Merged
Conversation
Zed had no remote scheme, so the Open picker fell back to VS Code for remote and SSH environments. The registry now records Zed's `zed://ssh/<host>/<path>` shape and the desktop allowlist validates that shape separately from VS Code remote links. Adapted from pingdotgg#11022. Implemented with Grok 4.6 High in Grok Build via Orca.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Greptile SummaryThis update adds Zed remote-project links and validates Zed SSH URLs before they are sent to the operating system. Encoded, lowercase-encoded, and nested-encoded host delimiters are rejected while valid remote-editor links remain supported. Confidence Score: 5/5Safe to merge. The previous P1 thread was resolved by greptile-apps[bot] without an explanatory reply. The current implementation decodes the Zed host segment and rejects @, :, /, and % characters, including nested encoding, which addresses the reported issue. Reviews (3): Last reviewed commit: "fix(desktop): reject nested Zed host enc..." | Re-trigger Greptile |
Decode the Zed host path segment before allowing the deep link so %40, %3A, and %2F cannot smuggle userinfo or extra path separators. Implemented with Grok 4.6 High in Grok Build via Orca.
This was referenced Sep 13, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Zed had no remote scheme in the editor registry, so remote and SSH environments fell back to VS Code even when Zed was installed on the viewing machine.
Fix
The registry now records
remoteScheme: "zed".buildRemoteOpenUrlemits Zed's documentedzed://ssh/<host>/<path>shape. The desktop shell allowlist validates that shape separately so a Zed link cannot ride in on a VS Code scheme or the reverse.Adaptation
Reviewed port of pingdotgg/t3code#11022. Windows drive-letter drop for Zed was described in the upstream body and is not in that commit's code; this PR matches the merged source.
Scope
This PR is Zed remote open only. Cookie isolation is #208. SSH runner ownership is #215. LAN vs Tailscale pairing is #217.
Verification
vp test runonElectronShell.test.tsandremoteOpen.test.ts: 20 passed.vp run --filter @t3tools/contracts --filter @t3tools/desktop --filter @t3tools/web typecheckexited 0.Native Zed on a remote SSH host was not launched from this Linux environment.
Implemented with Grok 4.6 High in Grok Build via Orca.