Fix SAI_STATUS_IS_* attribute-range helpers for negative status codes#2308
Open
MoriLevinzon wants to merge 1 commit into
Open
Fix SAI_STATUS_IS_* attribute-range helpers for negative status codes#2308MoriLevinzon wants to merge 1 commit into
MoriLevinzon wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2307
Two fixes in the
SAI_STATUS_IS_*helpers ininc/saistatus.h:SAI_STATUS_CODE(x)) before masking, so the rangecheck is correct for negative status codes on Linux. Previously a non-zero
attribute index borrowed across the 16-bit boundary and matched the wrong
range (e.g.
INVALID_ATTR_VALUEindex 3 classified asATTR_NOT_IMPLEMENTED).No-op on Windows, where
SAI_STATUS_CODEis identity.SAI_STATUS_IS_UNKNOWN_ATTRIBUTE, which compared againstSAI_STATUS_INVALID_ATTRIBUTE_0instead ofSAI_STATUS_UNKNOWN_ATTRIBUTE_0(wrong on all platforms).