docs: make PR descriptions plain-language first - #224
Conversation
Co-authored-by: hannesrudolph <49103247+hannesrudolph@users.noreply.github.com>
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 12, 2026, 3:39 PM ET / 19:39 UTC. ClawSweeper reviewWhat this changesThe PR shortens contributor prompts, places user impact before implementation rationale, and keeps risks and evidence summaries visible. Merge readiness⛔ Blocked before merge - 1 item remains This remains a useful, focused template improvement that is absent from main and the latest release. No actionable correctness or security defect was found. Priority: P3 Review scores
Verification
How this fits togetherDiscrawl’s GitHub pull request template guides contributors when writing descriptions. It organizes the problem, impact, rationale, and evidence that reviewers use to assess contributions. flowchart LR
A[Contributor opens a PR] --> B[Description template]
B --> C[Problem and user impact]
B --> D[Rationale and evidence]
C --> E[Reviewer assessment]
D --> E
Before merge
Agent review detailsSecurityNone. Review metricsNone. Technical reviewBest possible solution: Keep one concise repository template that leads with the problem and outcome while preserving visible risks, required actions, and validation evidence. Do we have a high-confidence way to reproduce the issue? Not applicable: this changes contribution guidance rather than repairing a runtime failure; the complete template and pinned diff were inspected. Is this the best way to solve the issue? Yes: editing the existing template is a narrow, maintainable way to improve descriptions without adding competing guidance or changing the required section names. AGENTS.md: found, but no applicable review policy affected this item. Codex review notes: model internal, reasoning medium; reviewed against 821d948f4a60. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Related: openclaw/openclaw#146253
What Problem This Solves
The template encouraged long descriptions before stating the user-visible outcome.
User Impact
Contributors receive shorter, plain-language prompts that keep risks, required actions and evidence visible. No runtime changes.
Why This Change Was Made
Apply the approved core template while retaining all four section names and the instruction to allow maintainer edits. Preserve Hannes Rudolph's contributor credit.
Evidence
355d87da2ae1d7df4e5b61062e95736ac2e60044;--versionreturned0.15.1-0.20260912193507-355d87da2ae1, andmetadata --jsoncontainedschema_version.