Repository navigation
fix: full page load for links between the landing page and the docs versions - #9
Merged
Merged
Conversation
…ersions The landing page and every docs version are separate VitePress apps. The client router of the app a link is clicked in handled links into another app and rendered its own 404 page. Links that leave the app now carry target="_self" (.vitepress/apps.ts: nav, hero actions, features, format list, quick start, version banner, 404 page), so the browser loads the page. Navigation links to the site root no longer open a new tab. check-links.ts fails on a link into another app without a target, and apps.test.ts builds the landing page and two docs apps to test it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The landing page and every docs version are separate VitePress apps. The
client router of the app a link is clicked in handled links into another app
and rendered its own 404 page. Links that leave the app now carry
target="_self" (.vitepress/apps.ts: nav, hero actions, features, format list,
quick start, version banner, 404 page), so the browser loads the page.
Navigation links to the site root no longer open a new tab.
check-links.ts fails on a link into another app without a target, and
apps.test.ts builds the landing page and two docs apps to test it.