Add directory property to RunShell by cvgaviao · Pull Request #1193 · open-workflow-specification/specification

cvgaviao · 2026-09-18T22:37:52Z

Please specify parts of this PR update:

#1191

What this PR does:
Added property directory to RunShell

Additional information:

Copilot

Copilot review overview

🟢 Approval recommended

The change is a small, additive, backwards-compatible schema extension that matches the linked issue’s request.

Review effort: Lite
Findings: None

What changed in this PR

This PR updates the workflow JSON Schema to support specifying a working directory for RunShell, addressing issue #1191 so shell commands can execute with an explicit working directory rather than inheriting the workflow application’s startup directory.

Changes:

Adds an optional directory string property to the RunShell.shell configuration object.
Documents the new property as the working directory used when running the shell command.

File	Description
schema/workflow.yaml	Extends the `RunShell` schema to allow an optional working-directory (`directory`) for shell execution.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

ricardozanini · 2026-09-28T14:44:28Z

@cvgaviao can you please also add a description of this new property to the dsl-reference.md and any other doc related to it?

Copilot

Copilot review overview

🟢 Approval recommended

No blocking issues were identified; remaining feedback is a minor documentation nit.

Review effort: Lite
Findings: None

cdavernas

LGTM! Cheers!

ricardozanini · 2026-09-28T15:31:28Z

@cvgaviao one more thing, you must commit with verified signatures.

cvgaviao · 2026-09-29T07:35:32Z

@ricardozanini , ok I will do it tonight.

Copilot

Copilot review overview

🟡 Changes recommended

The example uses tab indentation and fails YAML validation.

Review effort: Lite
Findings: 1

Open (1)

Replace tab indentation with spaces in YAML sequence · New

Copilot

Copilot review overview

🟢 Approval recommended

All reviewed changes are documented and no blocking issues were identified.

Review effort: Lite
Findings: None

Resolved since last review (1)

Replace tab indentation with spaces in YAML sequence

Copilot

Copilot review overview

🟡 Changes recommended

Add the schema property and replace tab indentation with spaces.

Review effort: Lite
Findings: 2

Open (2)

Add directory to the shell schema · New
Add directory to the RunShell schema · New

 | command | `string` | `yes` | The shell command to run |
 | stdin | `string` | `no` | A runtime expression, if any, to the shell command as standard input (stdin).|
 | arguments | `string[]` | `no` | A list of the arguments, if any, of the shell command to run |
+| directory | `string` | `no` | The working directory, if any, in which to run the shell command. |


-          - Bar
+          	- Foo
+          	- Bar
+          directory: /tmp


Copilot

Copilot review overview

🔵 Needs a closer look

Replace tab indentation in the example so it parses as valid YAML.

Review effort: Lite
Findings: 2

Open (2)

Add directory to the RunShell schema
Add directory to the shell schema

Signed-off-by: Cristiano Gavião <cvgaviao@gmail.com>

cvgaviao · 2026-09-29T20:56:28Z

@cvgaviao one more thing, you must commit with verified signatures.

It seems to be ok now. I will need to sign the other commits too.

ricardozanini · 2026-10-06T13:15:49Z

@cvgaviao can you have a look at the CI?

Copilot

Copilot review overview

🔵 Needs a closer look

Replace tab indentation in the YAML example before approval.

Review effort: Lite
Findings: 2

Open (2)

Add directory to the RunShell schema
Add directory to the shell schema

cvgaviao requested review from cdavernas and ricardozanini as code owners September 18, 2026 22:37

Copilot AI lite review requested due to automatic review settings September 18, 2026 22:37

Copilot started reviewing on behalf of cvgaviao September 18, 2026 22:38 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

ricardozanini linked an issue Sep 28, 2026 that may be closed by this pull request

Add missing optional directory property on the RunShell #1191

Open

Copilot AI review requested due to automatic review settings September 28, 2026 14:44

Copilot started reviewing on behalf of cvgaviao September 28, 2026 14:44 View session

Copilot AI reviewed Sep 28, 2026

View reviewed changes

cdavernas approved these changes Sep 28, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings September 29, 2026 19:14

cvgaviao force-pushed the main branch from daa41e4 to 11535fb Compare September 29, 2026 19:14

Copilot started reviewing on behalf of cvgaviao September 29, 2026 19:15 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Comment thread examples/run-shell-stdin-and-arguments.yaml

Copilot AI lite review requested due to automatic review settings September 29, 2026 19:20

cvgaviao force-pushed the main branch from 11535fb to c5f98cf Compare September 29, 2026 19:20

Copilot started reviewing on behalf of cvgaviao September 29, 2026 19:20 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings September 29, 2026 19:40

cvgaviao force-pushed the main branch from c5f98cf to f8ee843 Compare September 29, 2026 19:40

Copilot started reviewing on behalf of cvgaviao September 29, 2026 19:41 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Copilot AI lite review requested due to automatic review settings September 29, 2026 20:12

cvgaviao force-pushed the main branch from f8ee843 to 9b29b80 Compare September 29, 2026 20:12

Copilot started reviewing on behalf of cvgaviao September 29, 2026 20:12 View session

Copilot AI reviewed Sep 29, 2026

View reviewed changes

Add directory property to RunShell

fbc65a6

Signed-off-by: Cristiano Gavião <cvgaviao@gmail.com>

cvgaviao force-pushed the main branch from 9b29b80 to fbc65a6 Compare September 29, 2026 20:46

ricardozanini requested a lite review from Copilot October 6, 2026 13:15

Copilot started reviewing on behalf of ricardozanini October 6, 2026 13:16 View session

Copilot AI reviewed Oct 6, 2026

View reviewed changes

Conversation

cvgaviao commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

ricardozanini commented Sep 28, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

cdavernas left a comment

Choose a reason for hiding this comment

Uh oh!

ricardozanini commented Sep 28, 2026

Uh oh!

cvgaviao commented Sep 29, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟢 Approval recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🟡 Changes recommended

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

cvgaviao commented Sep 29, 2026

Uh oh!

ricardozanini commented Oct 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

🔵 Needs a closer look

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants