Fixes #28993: refactor(ingestion): migrate mlmodel/metadata/messaging connectors to BaseConnection#28994
Merged
Conversation
… BaseConnection Migrate mlflow, sagemaker (mlmodel); alationsink, amundsen, atlas (metadata); and kafka, kinesis, pubsub, redpanda (messaging) onto the BaseConnection[Config, Client] pattern, wiring connection_class into each service spec. The mlmodel/messaging base sources and the metadata sources all acquire their client and run test_connection through the generic resolver (source.connections), so the new classes are exercised end-to-end. kafka keeps its module-level get_connection/test_connection because redpanda imports them (get_kafka_connection/test_kafka_connection); both messaging clients are the shared KafkaClient. pubsub keeps get_connection module-level (a unit test imports it); the remaining six move the build into _get_client. Boto3-backed sagemaker/kinesis type the client as Any (matching glue/dynamodb). Add colocated connection unit tests for all nine.
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
github-actions
Bot
added
Ingestion
safe to test
Code Review ✅ ApprovedMigrates mlmodel, metadata, and messaging connectors to the BaseConnection pattern to improve structural consistency. No issues found. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Contributor
🟡 Playwright Results — all passed (12 flaky)✅ 4302 passed · ❌ 0 failed · 🟡 12 flaky · ⏭️ 88 skipped
🟡 12 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
pmbrull
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28993
What
Migrates the mlmodel, metadata and messaging connectors onto the
BaseConnection[Config, Client]pattern, continuing the connector-wide BaseConnection rollout.MlflowClient_get_clientAny)_get_clientAlationSinkClient_get_clientNeo4jHelper_get_clientAtlasClient_get_clientKafkaClientAny)_get_clientPubSubClientKafkaClientget_kafka_connectionHow
XConnection(BaseConnection[ConfigType, ClientType])with_get_clientandtest_connection;connection_classis wired into eachservice_spec.py.test_connectionthrough the generic resolver (metadata.ingestion.source.connections), so the new classes are exercised end-to-end — no source-side changes.get_connection/test_connection(aliased) and theKafkaClientdataclass, so kafka keeps those module-level and its class delegates to them; redpanda's class delegates to the aliased kafka functions.Any, matching the merged glue/dynamodb connectors.Tests
tests/unit/source/<type>/<connector>/test_connection.pyfor all nine (BaseConnection subclass, client build, test_connection dispatch).basedpyrightbaseline check clean;ruffclean.No behavior change — pure structural migration.