Fixes #28992: refactor(ingestion): migrate storage/search/drive connectors to BaseConnection#28991
Merged
Merged
Conversation
…onnection Migrate s3, gcs, elasticsearch, opensearch, sftp and googledrive onto the BaseConnection[Config, Client] pattern and wire connection_class into each service spec. The storage/search/drive base sources already obtain their client and run test_connection through the generic resolver (source.connections), so the new classes are exercised end-to-end. get_connection stays module-level for s3/gcs (sampler importers), sftp and googledrive (metadata importers) and opensearch (test importer); the class _get_client delegates to it. elasticsearch has no external importer so its build moves into _get_client. Add colocated connection unit tests for all six.
Contributor
✅ PR checks passedThe linked issue has a description and all required Shipping project fields set. Thanks! |
github-actions
Bot
added
Ingestion
safe to test
IceS2
changed the title
Code Review ✅ ApprovedMigrates storage, search, and drive connectors to the BaseConnection pattern to unify ingestion architecture. No issues found, with all structural changes validated by new unit tests and existing topology suites. OptionsDisplay: compact → Showing less information. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
|
Contributor
🟡 Playwright Results — all passed (13 flaky)✅ 4301 passed · ❌ 0 failed · 🟡 13 flaky · ⏭️ 88 skipped
🟡 13 flaky test(s) (passed on retry)
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
pmbrull
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28992
What
Migrates the storage, search and drive connectors onto the
BaseConnection[Config, Client]pattern, continuing the connector-wide BaseConnection rollout (database vertical already complete).Connectors in this batch:
S3ObjectStoreClientGcsObjectStoreClientElasticsearch_get_client(no importer)OpenSearchSftpClientGoogleDriveClientHow
XConnection(BaseConnection[ConfigType, ClientType])with_get_clientandtest_connection.connection_classis wired into eachservice_spec.py. The storage/search/drive base sources already build their client and runtest_connectionthrough the generic resolver (metadata.ingestion.source.connections), so the new classes are exercised end-to-end — no source-side changes needed.metadata.py) importsget_connectiondirectly, the function stays module-level and_get_clientdelegates to it; only elasticsearch (no external importer) moves the build inline.S3ObjectStoreClient,GcsObjectStoreClient), the GCSTester, and SSL helpers are left untouched.Tests
tests/unit/source/<type>/<connector>/test_connection.pyfor all six (BaseConnection subclass, client build, test_connection step dispatch).basedpyrightbaseline check clean;ruffclean.No behavior change — pure structural migration.