Skip to content

[lint] Don't report public global variables as unused#611

Merged
turbolent merged 1 commit into
masterfrom
bastian/improve-lint-unused-globals
Mar 19, 2026
Merged

[lint] Don't report public global variables as unused#611
turbolent merged 1 commit into
masterfrom
bastian/improve-lint-unused-globals

Conversation

@turbolent

Copy link
Copy Markdown
Member

Description

While adding the linter to FlowALP (see onflow/FlowALP#154), I noticed that the tests use global variables for constants.


  • Targeted PR against master branch
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work
  • Code follows the standards mentioned here
  • Updated relevant documentation
  • Re-reviewed Files changed in the Github PR explorer
  • Added appropriate labels

@turbolent turbolent self-assigned this Mar 19, 2026
@turbolent turbolent requested a review from SupunS as a code owner March 19, 2026 21:02
@turbolent turbolent added the Improvement Technical work without new features, refactoring, improving tests label Mar 19, 2026
@turbolent turbolent requested a review from RZhang05 as a code owner March 19, 2026 21:02
@turbolent turbolent merged commit 7b9319c into master Mar 19, 2026
10 checks passed
@turbolent turbolent deleted the bastian/improve-lint-unused-globals branch March 19, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Improvement Technical work without new features, refactoring, improving tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants