Skip to content

fix(desktop): restore sandboxed preload bridge - #389

Merged
NWYLZW merged 2 commits into
mainfrom
codex/fix-desktop-sandboxed-preload
Aug 20, 2026
Merged

fix(desktop): restore sandboxed preload bridge#389
NWYLZW merged 2 commits into
mainfrom
codex/fix-desktop-sandboxed-preload

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • bundle @oneworks/types into the sandboxed Electron preload so packaged Launcher windows receive window.oneworksDesktop
  • verify emitted preload bundles contain only sandbox-supported runtime require() calls
  • add a regression test, package-preflight coverage, stable module guidance, and the Desktop changelog entry

Changelog

  • Changelog path or "Not applicable": changelog/1.0.0-rc.4/desktop.md

Screenshots

Not applicable. This restores an existing Desktop bridge without changing the UI.

Validation

  • pnpm -C apps/desktop typecheck
  • pnpm -C apps/desktop test:package-preflight (16 files, 172 tests)
  • pnpm dprint check
  • pnpm exec eslint .
  • pnpm -C apps/desktop run package
  • pnpm -C apps/desktop smoke:package
  • installed macOS Dev app runtime verification of window.oneworksDesktop methods and Launcher IPC

Review Scope

  • Risk: medium
  • Applicable profiles: Desktop and dual runtime paths (RUNTIME-001, DESKTOP-002)
  • Evidence: emitted preload verification, regression tests, full package smoke, and installed-app runtime IPC verification
  • Rule exceptions: none

Experience Review

  • 已判断是否需要沉淀经验
  • 如需要,已运行 $post-task-experience-review
  • reviewer PASS / NOT APPLICABLE 后才进入 merge

Policy Conflict Review

  • Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS

@NWYLZW
NWYLZW requested review from a team as code owners August 20, 2026 05:46
@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
oneworks-dev Ignored Ignored Aug 20, 2026 5:46am

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience Review

Before merge, make sure the PR body contains this completed checklist:

## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer `PASS` / `NOT APPLICABLE` 后才进入 merge

Checklist to confirm:

  • Decide whether this PR produced reusable project experience.
  • If experience should be captured, run $post-task-experience-review.
  • Merge only after the independent reviewer reports PASS or NOT APPLICABLE for the Experience Review Result.
  • For workflow, permission, or release-rule documentation changes, also add this checked section to the PR body after an independent read-only conflict review:
## Policy Conflict Review
- [x] Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASS

@NWYLZW
NWYLZW merged commit 5f95b23 into main Aug 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant