feat(diagnostics): measure first real app action - #364
Conversation
|
Someone is attempting to deploy a commit to the oneworks Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Experience Review
Before merge, make sure the PR body contains this completed checklist:
## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer `PASS` / `NOT APPLICABLE` 后才进入 mergeChecklist to confirm:
- Decide whether this PR produced reusable project experience.
- If experience should be captured, run
$post-task-experience-review. - Merge only after the independent reviewer reports
PASSorNOT APPLICABLEfor the Experience Review Result. - For workflow, permission, or release-rule documentation changes, also add this checked section to the PR body after an independent read-only conflict review:
## Policy Conflict Review
- [x] Independent read-only reviewer checked workflow, permission, and release-rule conflicts and reported PASSeff5226 to
86e9823
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 86e982387a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
d19a555 to
14c225c
Compare
|
复审 latest head
另外,当前 PR 与 |
14c225c to
957f991
Compare
|
Addressed review comment
This rebase includes the current MR change set. The supplied validation evidence is 23 test files / 353 Vitest tests plus typecheck, full ESLint, dprint, client prepublish, relay build, and |
Summary
oneworks.app.first_actionoperation for the first real session action: submit, transport acceptance, first renderable assistant response, and terminal success/failure/termination.client-action-*correlation ID that the server reuses when the action actually runs.Why
Startup diagnostics previously ended at UI readiness, so they could not answer whether the user's first meaningful action was accepted and actually completed. This change adds that missing measurement boundary without putting diagnostics I/O on the application bootstrap critical path: the first-action operation and journal record are created lazily only after a real submit, and renderer reporting remains fire-and-forget.
Architecture and data truthfulness
terminatedbefore adapter shutdown and preservesfailed/terminatedif a later stop callback arrives.This PR's measurable change
This PR establishes a measurement surface; it does not claim a startup-latency improvement. No same-artifact runtime A/B cohort was collected, so no latency percentage is reported.
The next runtime cohort can now provide actual first-action latency and success-rate deltas. Provider-side
first_tokenis deliberately not inferred from a complete renderer message and remains separate follow-up work.Changelog
changelog/1.0.0-rc.4/readme.mdScreenshots
No visual behavior changes. This is the existing real chat surface whose message-renderability contract is reused for
first.response.received; no placeholder or simulated composer was added.Validation
pnpm typecheck.pnpm exec eslint ..pnpm exec dprint check.git diff --check.Review Scope
Scope and follow-up
first.response.receivedmeans the renderer observed content that the real message UI can display. It is deliberately not provider-sidefirst_token.Experience Review
$post-task-experience-reviewPASS/NOT APPLICABLE后才进入 merge