π‘οΈ Sentinel: [CRITICAL] Fix command injection in text-to-speech - #73
π‘οΈ Sentinel: [CRITICAL] Fix command injection in text-to-speech#73omsingh02 wants to merge 1 commit into
Conversation
Encoded user-controlled text in Base64 before executing it via PowerShell to prevent escaping strings and running arbitrary commands. Co-authored-by: omsingh02 <215121080+omsingh02@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command Injection. The application passed unescaped, user-controlled text directly into a
powershell -Commandinvocation for text-to-speech. An attacker could craft a payload (e.g., escaping the double quotes) to execute arbitrary commands on the host Windows machine.π― Impact: Arbitrary code execution on the underlying host system, leading to full system compromise.
π§ Fix: Replaced direct string interpolation with a safe mechanism. The text payload is now Base64-encoded in Python (using
utf-16leto match PowerShell's expected encoding), and decoded securely entirely within the PowerShell context, ensuring it is always evaluated as string data, never as executable code.β Verification: Verified that tests pass (no regressions introduced) and manually verified that the script correctly executes standard T-T-S while rejecting payload escaping.
PR created automatically by Jules for task 6048120523041097137 started by @omsingh02