π‘οΈ Sentinel: [CRITICAL] Fix command injection in text-to-speech - #69
π‘οΈ Sentinel: [CRITICAL] Fix command injection in text-to-speech#69omsingh02 wants to merge 1 commit into
Conversation
The feedback service interpolated user input directly into a `powershell -Command` string. This change securely encodes the payload in Base64 (using utf-16le to match PowerShell's Unicode encoding) and passes it to PowerShell, preventing arbitrary command execution. Co-authored-by: omsingh02 <215121080+omsingh02@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: The
FeedbackManager.speak_textfunction on Windows interpolated raw user input (text) directly into a string executed bysubprocess.Popen(["powershell", "-Command", ...]). An attacker could exploit this by providing a maliciously crafted text string to break out of the string context and execute arbitrary PowerShell commands on the host machine.π― Impact: Remote Code Execution (RCE) or local privilege escalation, depending on where the
textinput originates from within the application (e.g. metadata of a recognized song). An attacker could gain full control over the user's system running the application on Windows.π§ Fix:
utf-16leencoding.$synth.Speak().β Verification:
pytest src/) execute without errors.FeedbackManager.speak_textfunction continues to behave normally on all supported operating systems.PR created automatically by Jules for task 18274673868750369412 started by @omsingh02