Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in text-to-speech - #67

Open
omsingh02 wants to merge 1 commit into
mainfrom
fix-command-injection-2216787331064323889
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in text-to-speech#67
omsingh02 wants to merge 1 commit into
mainfrom
fix-command-injection-2216787331064323889

Conversation

@omsingh02

Copy link
Copy Markdown
Owner

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: The speak_text function in src/services/feedback.py used direct string interpolation to construct a PowerShell script passed to subprocess.Popen. This allowed an attacker to break out of the string context and execute arbitrary PowerShell commands via crafted input (e.g., Hello "; Write-Host "Hacked).
🎯 Impact: Remote Code Execution (RCE) / OS Command Injection, allowing arbitrary command execution on Windows platforms.
πŸ”§ Fix: Encoded the text payload using Base64 (utf-16le encoding to match PowerShell's [System.Text.Encoding]::Unicode) in Python, and decoded it within the PowerShell script using [Convert]::FromBase64String. This safely sanitizes the payload without needing complex character escaping.
βœ… Verification: Ran syntax checks (python -m compileall src/) and verified code modification to ensure text is correctly encoded and decoded.


PR created automatically by Jules for task 2216787331064323889 started by @omsingh02

Co-authored-by: omsingh02 <215121080+omsingh02@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant