π‘οΈ Sentinel: [CRITICAL] Fix command injection in PowerShell TTS - #54
π‘οΈ Sentinel: [CRITICAL] Fix command injection in PowerShell TTS#54omsingh02 wants to merge 1 commit into
Conversation
β¦ding Co-authored-by: omsingh02 <215121080+omsingh02@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Direct string interpolation of an untrusted
textargument into a PowerShell script executed viasubprocess.PopeninFeedbackManager.speak_text(). An attacker could break out of the string wrapper (using quotes and semicolons) to achieve arbitrary command execution on Windows.π― Impact: Malicious input passed to the TTS engine could compromise the host machine with the privileges of the running application.
π§ Fix: Changed the input passing mechanism. Python now Base64 encodes the TTS text payload, safely passes only the Base64 string to PowerShell, and PowerShell natively decodes it back to UTF-8 before passing it to the
SpeechSynthesizer. This removes any string interpolation risks.β Verification: Verified by ensuring the code behaves safely even if the
textincludes characters like"or;because the string is transported safely as base64. Also ensured Python syntax passes compilation and the test suite passes smoothly. Added entry to.jules/sentinel.mdjournal.PR created automatically by Jules for task 6490587686477468003 started by @omsingh02