fix(plot): 修复 loop 动画仅执行一轮 - #79
Merged
Merged
Conversation
wang-kaopu
force-pushed
the
fix/plot-loop-animation
branch
from
August 28, 2026 13:20
d1e50e8 to
663e58e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
Plot 参数动画开启
loop: true后只运行一轮。旧实现完成一轮时调用:
setPlaying(p => p)这不会改变 state,因此不会重新触发 animation effect,下一轮动画不会真正启动。
修复
让同一个 RAF animation chain 在一轮结束后直接开始下一 cycle:
测试
新增 fake RAF / performance 回归测试:
loop: true可以进入第二轮;验证
提交 PR 前已执行:
pnpm run checklib/产物