refactor: shared plugin command runner in @chkit/core#175
Open
KeKs0r wants to merge 1 commit into
Open
Conversation
Add createPluginRunner and withFactoryDefaults to @chkit/core and use them in the backfill, codegen, and pull plugins, replacing the wrapPluginRun wiring repeated on all 9 commands and the byte-identical withFactoryDefaults/isRecord copies in each plugin. No behavior change. Removes the ~350-line cross-plugin structural clone flagged by fallow; duplication drops from 5.09% to 2.37%.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createPluginRunnerandwithFactoryDefaultsto@chkit/core— the error-to-exit-coderunwrapper and registration-options layering that the backfill, codegen, and pull plugins each carried as private copies.@chkit/coreand the three plugins, since the plugins now require the matching core version.Test plan
bun verify(typecheck, lint, test, build — 37/37 tasks) including live-ClickHouse e2e for backfill, pull, and the CLI plugin-dispatch/usage-error suitesfallow dupesre-run confirms the cross-plugin clone family is gone