feat: improve the solar transit for the apparent hour angle in night module in @observerly/astrometry

[michealroberts]

No description provided.

[Copilot]

🟢 Approval recommended

The behavioral change is consistently applied in the implementation and tests, and the only noted concern is a non-blocking maintainability improvement (shared helper extraction).

Pull request overview

This PR updates the night/solar-transit calculations to resolve solar transit and horizon-crossing events using the Sun’s apparent hour angle (LAST-based), aligning the night module’s behavior with how apparent solar right ascension is defined and improving conformance to SPA references.

Changes:

• Switch getSolarTransit()/isNight() to use apparent-hour-angle-based solar altitude evaluation (including refraction correction) instead of convertEquatorialToHorizontal().
• Update expected timestamps in tests/night.spec.ts to match the refined event resolution.
• Tighten SPA conformance expectations for refined solar-noon residuals by reducing MERIDIAN_TRANSIT_TOLERANCE.

File summaries

File	Description
src/night.ts	Computes apparent solar altitude from apparent hour angle and uses it in getSolarTransit() and isNight() to refine event timing.
tests/night.spec.ts	Updates expected sunrise/noon/sunset/night timestamps and adjusts altitude cross-checking to match the new apparent-hour-angle basis.
tests/conformance/spa.spec.ts	Updates documentation and tightens the refined meridian-transit tolerance to reflect improved alignment.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.