Repository navigation
fix: log errors at the http level - #15
Merged
Merged
Conversation
Signed-off-by: Donnie Adams <donnie@obot.ai>
There was a problem hiding this comment.
🟢 Approval recommended
The change is limited in scope; the requested regression test is a minor nit.
Pull request overview
Adds HTTP-level logging for frontend identity resolution failures.
Changes:
- Logs registry errors through the configured logger.
- Preserves authorization capture and HTTP 500 behavior.
File summaries
| File | Summary |
|---|---|
http.go |
Logs frontend identity resolution failures. |
Review details
Suppressed comments (1)
http.go:66
- This adds the PR's observable behavior, but no HTTP test exercises the registry-failure path or verifies that the configured logger receives the error. Please add a regression test with a capturing
slog.Handlerand a discovery failure so this logging contract cannot regress silently.
if logger := c.serverOptions.Logger; logger != nil {
logger.ErrorContext(r.Context(), "resolving frontend identity", "error", err)
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
calvinmclean
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.