You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Confirm and fix the root-owned 0755 vs unprivileged daemon EACCES boundary for the targeted orphan-repair checkpoint seam.
Design
Use a private run-scoped daemon-owned 0700 directory under $STATE_ROOT/data.
Keep checkpoint publication and release waiting fail-closed before unbind/release.
Capture bounded sanitized publication step/kind/errno fields in both collectors.
Run a pre-VM publisher plus checkpoint/waiter/release diagnostic.
Evidence
The focused child-process regression reproduced temporary_create / permission_denied with errno under the root-owned legacy layout and passed publication/release under the daemon-owned corrected layout.
Validation
Focused compute tests: 110 passed.
Five PostgreSQL tests: passed against fresh guarded o3k_p13_test_1051_pg_1790684931, owned by o3k, then dropped.
Governed nextest/workspace PostgreSQL failures from the earlier run were due to missing destructive DB purpose configuration; the five blocked tests were subsequently rerun successfully with the guarded disposable database.
Scope and non-goals
No networking, scheduling, lease, P11 v3/fabric, S5, host-maintenance, or #1035 redesign changes. Protected 1035-crash-recovery was dispatched once as run 36573826866 and blocked before the acceptance lane by an immutable-checkout guard mismatch. #1035 remains open and PP.5 certification is not claimed.
Approval gate
New approval required for exact commit 3d99d80dd8eefa68e39e3f9399faa6951acbe63e; protected 1035-crash-recovery may run once after all checks pass.
Review request for exact final commit 39bd389e0f32d350104dd08c558535f56ad369cb.
The initial CI run found and I corrected only a test-placement issue: the unprivileged boundary regression now lives in src/checkpoint_tests.rs, so maintainability architecture guards pass without changing production behavior. Local focused tests, full workspace clippy, fmt, guards, and guarded PostgreSQL validation are green.
Please approve this exact commit after CI is green. I will not dispatch protected 1035-crash-recovery until that approval is recorded; #1046 remains frozen.
CI is green for exact head 3d99d80dd8eefa68e39e3f9399faa6951acbe63e (run 36580174477). Please review and approve this new commit. The prior approval was for 39bd389e and does not authorize this changed commit; no protected dispatch will occur until approval is recorded for 3d99d80d.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Fix #1051 as a narrow follow-up to #1046.
Depends on #1046 and keeps #1046 frozen.
Intent
Confirm and fix the root-owned 0755 vs unprivileged daemon EACCES boundary for the targeted orphan-repair checkpoint seam.
Design
$STATE_ROOT/data.Evidence
The focused child-process regression reproduced
temporary_create / permission_deniedwith errno under the root-owned legacy layout and passed publication/release under the daemon-owned corrected layout.Validation
o3k_p13_test_1051_pg_1790684931, owned byo3k, then dropped.Scope and non-goals
No networking, scheduling, lease, P11 v3/fabric, S5, host-maintenance, or #1035 redesign changes. Protected 1035-crash-recovery was dispatched once as run 36573826866 and blocked before the acceptance lane by an immutable-checkout guard mismatch. #1035 remains open and PP.5 certification is not claimed.
Approval gate
New approval required for exact commit
3d99d80dd8eefa68e39e3f9399faa6951acbe63e; protected1035-crash-recoverymay run once after all checks pass.