Skip to content

TDT-2791 Clarify event visibility default is Google-only#754

Merged
samLRodrigues merged 2 commits into
mainfrom
fix/event-visibility-google-only
Jul 7, 2026
Merged

TDT-2791 Clarify event visibility default is Google-only#754
samLRodrigues merged 2 commits into
mainfrom
fix/event-visibility-google-only

Conversation

@samLRodrigues

@samLRodrigues samLRodrigues commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

What

Updates the JSDoc for the Visibility type in src/models/events.ts to note that default only works for Google events. Microsoft and EWS accounts return a 400 error when default is sent, but the type declaration didn't warn about this.

Jira: TDT-2791 (sub-task of TDT-2765)

🤖 Generated with Claude Code

The Visibility JSDoc allowed 'default' for all providers without
noting that Microsoft and EWS accounts reject it with a 400 error.
Only Google events support 'default'.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.75%. Comparing base (d5a47c6) to head (62da1b6).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   98.75%   98.75%           
=======================================
  Files          43       43           
  Lines        1041     1041           
  Branches       90       90           
=======================================
  Hits         1028     1028           
  Misses         12       12           
  Partials        1        1           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@AaronDDM AaronDDM left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good afternoon! Thanks for tightening this up — the note is accurate and the provider-specific 400 behaviour is worth calling out. One thing before this ships: there's no entry under the Unreleased section in CHANGELOG.md. Please add a short line under Changed (e.g. "Clarify that event default visibility is Google-only") so the doc fix is tracked. Docs themselves look good.

@cursor

cursor Bot commented Jul 7, 2026

Copy link
Copy Markdown

Bugbot is not enabled for this team, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@samLRodrigues samLRodrigues merged commit cd785ad into main Jul 7, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants