Repository navigation
ELEMENTS-2115: Remove unused Sauce Labs wiring from the CI workflows [develop-2025] - #1763
Open
naveen-konda wants to merge 1 commit into
Open
naveen-konda wants to merge 1 commit into
naveen-konda wants to merge 1 commit into
Conversation
Dead plumbing left over from the Karma to Web Test Runner migration. Nothing in this repo consumes Sauce Labs: `npm run test` is `web-test-runner` against a Puppeteer-bundled Chromium, as `test.yaml` already documents in a comment on the step itself. There is no `sauce*` package in `package.json` or `package-lock.json`. - `test.yaml` - remove the `SAUCE_ACCESS_KEY` entry from `workflow_call.secrets`. It was declared `required: true` but never referenced by any step, which is also a latent trap: any new caller of `test.yaml` that omits the key fails at startup for a reason unrelated to the change being made. - `main.yaml`, `develop.yaml` - stop passing the secret into `test.yaml`. - `cross-repo.yaml` - stop sending `sauce_labs` in the `nuxeo-web-ui` dispatch inputs. `develop.yaml` is not listed in the ticket - it passes the same dead secret into `test.yaml` and so has to change in the same commit, otherwise the reusable-workflow call fails on an undeclared secret. Must merge before WEBUI-2369, which removes the `sauce_labs` input from the Web UI `cross-repo.yaml`. A `workflow_dispatch` carrying an input the target workflow no longer declares is rejected, so if the Web UI side lands first this repo's cross-repo check breaks. Removing the line here first is safe in either order: an input that is declared but not sent is simply unused. No repository secret is deleted by this change. Scope item B is deliberately left open - `GKE_SA_KEY`, `GKE_PROJECT` and `SAUCE_ACCESS_KEY` are retained by team decision. (cherry picked from commit d456f1e)
naveen-konda
requested review from
narasimhahyland and
vivekchaturved013
and
a balanced review from Copilot
and removed request for
a team
October 17, 2026 16:45
This was referenced Oct 17, 2026
This was referenced Oct 17, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
Workflow callers remain consistent, and the receiving workflow’s default preserves dispatch behavior.
No open issues 🎉
What changed in this PR
Removes unused Sauce Labs wiring from CI while leaving repository secrets unchanged.
Changes:
- Removes the test workflow’s Sauce Labs secret requirement and both callers’ secret forwarding.
- Stops sending
sauce_labsto Web UI; merge before WEBUI-2369 to preserve dispatch compatibility.
| File | Description |
|---|---|
.github/workflows/test.yaml |
Removes the unused secret declaration. |
.github/workflows/main.yaml |
Stops forwarding the secret from release CI. |
.github/workflows/develop.yaml |
Stops forwarding the secret from development CI. |
.github/workflows/cross-repo.yaml |
Removes the obsolete dispatch input. |
Review effort: Balanced
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Dead Sauce Labs plumbing left over from the Karma → Web Test Runner migration. Nothing in this repo consumes Sauce Labs:
npm run testisweb-test-runneragainst a Puppeteer-bundled Chromium —test.yamlalready documents this in a comment on the step itself.sauce*package inpackage.jsonorpackage-lock.json.SAUCE_ACCESS_KEYappears on the active branches only inmain.yaml,develop.yamlandtest.yaml— never in a step.Yet the credential is passed into a reusable workflow that executes the whole dev dependency tree, for no benefit.
test.yamlalso declared itrequired: true, which is a latent trap: any new caller that omits the key fails at startup for a reason unrelated to the change being made.Changes
test.yamlSAUCE_ACCESS_KEYentry fromworkflow_call.secretsmain.yamltest.yamldevelop.yamlcross-repo.yamlsauce_labsin thenuxeo-web-uidispatch inputsSix deleted lines, no additions.
Beyond the ticket
develop.yamlis not in ELEMENTS-2115's scope list, but it passes the same dead secret intotest.yaml. It has to change in the same commit — otherwise the reusable-workflow call fails on an undeclared secret.Test plan
git grep -E "SAUCE|sauce_labs" -- .github/→ no matches on this branch.cross-repo.yamldispatch still triggers the Web UI cross-repo check.Notes
WEBUI-2369 removes the
sauce_labsinput declaration fromnuxeo-web-ui'scross-repo.yaml. This PR removes the matching send here. Aworkflow_dispatchAPI call carrying an input the target workflow no longer declares is rejected with422 Unexpected inputs provided.Order matters in one direction only:
sauce_labs; an input that is declared but not sent is simply unused.That dispatch is live traffic, not theoretical —
cross-repo.yamlruns completed as recently as today.Scope item B — repository secrets
Deliberately not done.
GKE_SA_KEY,GKE_PROJECTandSAUCE_ACCESS_KEYare retained by team decision. This PR deletes no secret.Fixes ELEMENTS-2115