test: migrate remaining e2e tests to v2#2691
Open
fseldow wants to merge 1 commit into
Open
Conversation
fseldow
requested review from
binbin-li,
jimmyraywv,
luisdlp,
susanshi and
toddysm
as code owners
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
=======================================
Coverage 78.62% 78.62%
=======================================
Files 105 105
Lines 4664 4664
=======================================
Hits 3667 3667
Misses 848 848
Partials 149 149 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR continues the v1→v2 e2e migration effort by unskipping/migrating two remaining Bats tests and clarifying skip reasons for tests that are not applicable (or not yet portable) on the v2 executor model.
Changes:
- Migrates “validate crd add, replace and delete” to v2 by swapping the Executor CRD to a fixture without the notation verifier, then restoring the original executor.
- Unskips “validate mutation tag to digest” for v2.
- Updates multiple
skipmessages with v2-specific rationale (e.g., removed v1 CRDs, v2 e2e settings, and executor scoping constraints).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fseldow
force-pushed
the
xinhl/e2e-remaining
branch
9 times, most recently
from
d2f3143 to
3329ce7
Compare
Migrated tests: - validate crd add/replace/delete: jq patch executor to remove notation verifier - store crd status check: patch executor with invalid store, check error in status - validate mutation tag to digest: works as-is - validate inline certificate store provider: jq patch executor cert - validate inline key management provider: jq patch executor cert - validate inline KMP with cert store: verify executor cert config works - validate image signed by leaf cert: jq patch executor with root/leaf cert Updated skip messages: - crd version test: v2 has only v2alpha1 - CRL test: v2 hardcodes strict verification level - namespace certs test: v2 no namespace-scoped executor (notaryproject#2672) - cosign test: IgnoreTLog=false for key-based - cosign legacy keyed/keyless: v2 no legacy format - cosign keyless: TODO migrate - validate crd add/replace/delete: cosign IgnoreTLog blocks test - K8s secrets auth: static credential provider in e2e - tls cert rotation: disabled in e2e - namespaced verifiers: no namespace-scoped executor Signed-off-by: Xinhe Li <xinhl@microsoft.com> Signed-off-by: xinhl <xinhl@microsoft.com>
fseldow
force-pushed
the
xinhl/e2e-remaining
branch
from
3329ce7 to
2bdcec5
Compare
charleswool
reviewed
Jul 8, 2026
| assert_success | ||
| } | ||
|
|
||
| @test "validate inline key management provider with inline certificate store" { |
Contributor
There was a problem hiding this comment.
do we still need this test for v2 does not distinct key management provider and certstore name?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrated tests
executor_no_notation.yamlfixture to test executor without notation verifierUpdated skip messages
Test plan