Skip to content

feat: forward in-memory certs_keys in build_client_ssl_opts - #8

Merged
josecriane merged 2 commits into
mainfrom
feat/tls-in-memory-client-certs
Aug 21, 2026
Merged

feat: forward in-memory certs_keys in build_client_ssl_opts#8
josecriane merged 2 commits into
mainfrom
feat/tls-in-memory-client-certs

Conversation

@josecriane

Copy link
Copy Markdown
Member

No description provided.

@josecriane
josecriane force-pushed the feat/tls-in-memory-client-certs branch from 0affb65 to c9dad41 Compare August 21, 2026 08:31
@mrrubinos

Copy link
Copy Markdown
Contributor

Shouldn't we collapse these fields into something where precedence is explicitly declared?

certfile => file:filename(),
keyfile => file:filename(),
certs_keys => [map()],
cacertfile => file:filename(),
cacerts => [public_key:der_encoded()],

apart from that, LGTM

@josecriane

Copy link
Copy Markdown
Member Author

As indicated in ssl documentation, https://www.erlang.org/doc/apps/ssl/ssl.html#t:common_option_legacy/0, ​​certfile, keyfile, cacertfile, and cacerts are deprecated options in favor of certs_keys.

In newer versions of nhttp_lib, we should remove legacy options.

@josecriane
josecriane merged commit ca0f5f2 into main Aug 21, 2026
2 checks passed
@josecriane
josecriane deleted the feat/tls-in-memory-client-certs branch August 21, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants