Skip to content

chore: update to node 26 and use t.assert mock assertions - #1171

Open
araujogui wants to merge 1 commit into
nodejs:mainfrom
araujogui:chore/node-26.12
Open

araujogui wants to merge 1 commit into
nodejs:mainfrom
araujogui:chore/node-26.12

Conversation

@araujogui

@araujogui araujogui commented Oct 20, 2026 •

Copy link
Copy Markdown
Member

Bumps .nvmrc and @types/node to v26, and rewrites mock checks in tests with the new t.assert.callCount / t.assert.nthCalledWith from nodejs/node#66476.

@araujogui
araujogui requested a review from a team as a code owner October 20, 2026 23:27
Copilot AI balanced review requested due to automatic review settings October 20, 2026 23:27
@vercel

vercel Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
api-docs-tooling Ready Ready Preview Nov 3, 2026 11:14pm UTC

Request Review

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.14%. Comparing base (c8b228e) to head (8ac6cb9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1171      +/-   ##
==========================================
- Coverage   94.14%   94.14%   -0.01%     
==========================================
  Files         291      291              
  Lines       28950    28908      -42     
  Branches     2944     2936       -8     
==========================================
- Hits        27256    27214      -42     
  Misses       1672     1672              
  Partials       22       22              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

api-links Generator

Performance estimate (single CI run)

  • Generation time: 32.4% faster (1.05 s → 710.00 ms)
  • Peak memory: 2.8% lower (293.49 MB → 285.27 MB)

json Generator

Performance estimate (single CI run)

  • Generation time: 5.1% faster (9.48 s → 9.00 s)
  • Peak memory: 8.2% lower (997.38 MB → 915.29 MB)

legacy-html Generator

Performance estimate (single CI run)

  • Generation time: 3.5% faster (12.36 s → 11.93 s)
  • Peak memory: 6.4% lower (1.52 GB → 1.42 GB)

legacy-json Generator

Performance estimate (single CI run)

  • Generation time: 11.2% slower (7.23 s → 8.04 s)
  • Peak memory: 2.5% lower (934.98 MB → 911.50 MB)

llms-txt Generator

Performance estimate (single CI run)

  • Generation time: 29.2% faster (8.43 s → 5.97 s)
  • Peak memory: 4.2% lower (864.12 MB → 827.92 MB)

orama-db Generator

Performance estimate (single CI run)

  • Generation time: 27.2% faster (8.82 s → 6.42 s)
  • Peak memory: 2.1% higher (992.37 MB → 1012.86 MB)

web Generator

Output size: 68 files changed · net -156.00 B

File size details
File Main PR Change
assets/SearchBox-B02nSGjT.js 84.55 KB — -84.55 KB (-100.0%)
assets/SearchBox-9n1mnHaB.js — 84.55 KB +84.55 KB
assets/dist-C1c5nNoD.js 30.37 KB — -30.37 KB (-100.0%)
assets/dist-CnIJ8XGP.js — 30.37 KB +30.37 KB
assets/SideBar-_Lc7Hke4.js 25.53 KB — -25.53 KB (-100.0%)
assets/SideBar-DHTYk6TC.js — 25.53 KB +25.53 KB
assets/client-Cd-ofeiT.js 25.44 KB — -25.44 KB (-100.0%)
assets/client-CqREPnK9.js — 25.44 KB +25.44 KB
assets/config-CuxGjF-k.js 24.15 KB — -24.15 KB (-100.0%)
assets/config-DrqSsa0t.js — 24.15 KB +24.15 KB
assets/Combination-CJrKa7in.js 16.07 KB — -16.07 KB (-100.0%)
assets/Combination-BqcNYhpf.js — 16.07 KB +16.07 KB
assets/ThemeToggle-BkRRTvhg.js 13.61 KB — -13.61 KB (-100.0%)
assets/ThemeToggle-CwTAxrWI.js — 13.61 KB +13.61 KB
assets/compat-DhAJLazI.js 13.53 KB — -13.53 KB (-100.0%)
assets/compat-DkeB9U1h.js — 13.53 KB +13.53 KB
assets/dist-DEBPYQj9.js 10.16 KB — -10.16 KB (-100.0%)
assets/dist-BLH_Rr38.js — 10.16 KB +10.16 KB
assets/Layout-CF37ALDT.js 10.04 KB — -10.04 KB (-100.0%)
assets/Layout-BfF00dNX.js — 10.04 KB +10.04 KB
assets/Tooltip-CvSkILIT.js 7.84 KB — -7.84 KB (-100.0%)
assets/Tooltip-CnMYlYFs.js — 7.84 KB +7.84 KB
assets/dist-AcA-EeFs.js 6.95 KB — -6.95 KB (-100.0%)
assets/dist-CLGhXHiW.js — 6.95 KB +6.95 KB
assets/dist-Bt3DtgZ8.js 3.89 KB — -3.89 KB (-100.0%)
assets/dist-Bv2VMEdQ.js — 3.89 KB +3.89 KB
assets/CodeTabs-D2WUFE8S.js 3.81 KB — -3.81 KB (-100.0%)
assets/CodeTabs-wEu7sdiy.js — 3.81 KB +3.81 KB
assets/CodeBox-AMX1D-hj.js 3.36 KB — -3.36 KB (-100.0%)
assets/CodeBox-YXLF9NRO.js — 3.36 KB +3.36 KB
assets/FunctionSignature-Bt9h0FbT.js 2.20 KB — -2.20 KB (-100.0%)
assets/FunctionSignature-D8zqozIh.js — 2.20 KB +2.20 KB
assets/Banner-DvsTMKFC.js 2.04 KB — -2.04 KB (-100.0%)
assets/Banner-4fGaX6F9.js — 2.04 KB +2.04 KB
assets/ChangeHistory-DW7JMJHT.js 1.73 KB — -1.73 KB (-100.0%)
assets/ChangeHistory-D0IPdHvy.js — 1.73 KB +1.73 KB
assets/DataTag-6r9EZxAu.js 834.00 B — -834.00 B (-100.0%)
assets/DataTag-CwRk7EUJ.js — 834.00 B +834.00 B
assets/DocumentationIndex-mP0hv2sA.js 833.00 B — -833.00 B (-100.0%)
assets/DocumentationIndex-DJHHnKq0.js — 833.00 B +833.00 B
assets/classnames-VhZvwNjh.js 745.00 B — -745.00 B (-100.0%)
assets/classnames-B4RBm4Lf.js — 745.00 B +745.00 B
assets/Badge-AdP9kO3i.js 597.00 B — -597.00 B (-100.0%)
assets/Badge-BbGRrcF2.js — 597.00 B +597.00 B
assets/AlertBox-BuS7UO2k.js 581.00 B — -581.00 B (-100.0%)
assets/AlertBox-CRH0CiNU.js — 581.00 B +581.00 B
assets/ArrowUpRightIcon-CSFeAssb.js 579.00 B — -579.00 B (-100.0%)
assets/ArrowUpRightIcon-GB8x2WWs.js — 579.00 B +579.00 B
assets/CodeBracketIcon-DIy4V2YI.js 512.00 B — -512.00 B (-100.0%)
assets/CodeBracketIcon-CDCxizh2.js — 512.00 B +512.00 B
assets/dist-BQjbpaMG.js 477.00 B — -477.00 B (-100.0%)
assets/dist-sScOyttL.js — 477.00 B +477.00 B
assets/ChevronDownIcon-DwJOl7gr.js 468.00 B — -468.00 B (-100.0%)
assets/ChevronDownIcon-BmLGedWk.js — 468.00 B +468.00 B
assets/renderLabel-DJelS0Rb.js 447.00 B — -447.00 B (-100.0%)
assets/renderLabel-CchXvpBp.js — 447.00 B +447.00 B
assets/jsx-runtime-MKL6DAmk.js 405.00 B — -405.00 B (-100.0%)
assets/jsx-runtime-DGWrY2l7.js — 405.00 B +405.00 B
assets/Blockquote-CP2tTK57.js 167.00 B — -167.00 B (-100.0%)
assets/Blockquote-_Mfd8Z3h.js — 167.00 B +167.00 B
assets/useRemoteConfig-BZOwsmPm.js 116.00 B — -116.00 B (-100.0%)
assets/useRemoteConfig-BX7tuC1U.js — 116.00 B +116.00 B
assets/withIsland-63DpqwhK.js 105.00 B — -105.00 B (-100.0%)
assets/withIsland-wjSwvMAn.js — 105.00 B +105.00 B
bench.html 213.44 KB 213.40 KB -39.00 B (-0.0%)
dtls.html 315.63 KB 315.59 KB -39.00 B (-0.0%)
ffi.html 204.00 KB 203.96 KB -39.00 B (-0.0%)
vfs.html 213.64 KB 213.60 KB -39.00 B (-0.0%)

Performance estimate (single CI run)

  • Generation time: 36.2% faster (23.90 s → 15.24 s)
  • Peak memory: 4.0% higher (1.48 GB → 1.53 GB)

@avivkeller

Copy link
Copy Markdown
Member

@araujogui Is this version LTS?

@araujogui

Copy link
Copy Markdown
Member Author

@MattIPv4

MattIPv4 commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

@araujogui Is this version LTS?

Yes, https://nodejs.org/en/blog/announcements/evolving-the-nodejs-release-schedule#nodejs-27-schedule-new-model#nodejs-26-schedule-existing-model

26.12 is not LTS, per https://nodejs.org/dist/index.json. An existing release does not magically become LTS because a date has passed, it is the first release after that date which will gain the LTS flag.

@araujogui

Copy link
Copy Markdown
Member Author

@araujogui Is this version LTS?

Yes, https://nodejs.org/en/blog/announcements/evolving-the-nodejs-release-schedule#nodejs-27-schedule-new-model#nodejs-26-schedule-existing-model

26.12 is not LTS, per https://nodejs.org/dist/index.json. An existing release does not magically become LTS because a date has passed, it is the first release after that date which will gain the LTS flag.

Let's wait for LTS then, it should be close.

@ovflowd
ovflowd marked this pull request as draft October 25, 2026 11:15
@ovflowd

ovflowd commented Oct 25, 2026

Copy link
Copy Markdown
Member

Converting to draft till we reach LTS

@araujogui

Copy link
Copy Markdown
Member Author

Node.js 26 is now LTS 🥳

@araujogui araujogui changed the title chore: update to node 26.12 and use t.assert mock assertions chore: update to node 26 and use t.assert mock assertions Nov 3, 2026

This branch was successfully deployed

1 active deployment
Preview – api-docs-tooling — 8ac6cb9c Deployed Nov 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants