Fix inner product distance code to vectorize on arm (affects all arch)#668
Open
pmiloslavsky wants to merge 2 commits into
Open
Fix inner product distance code to vectorize on arm (affects all arch)#668pmiloslavsky wants to merge 2 commits into
pmiloslavsky wants to merge 2 commits into
Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed inner product code to vectorize by removing inner loop use of
void.Changed
example_searchto also demonstrate use of IP space with normalization and print index build timing.Validation
Disassembled
example_searchInnerProductDistancewith gdb and checked forfmlainstruction on ARM, Ubuntu 24 ARM.gdb -batch -ex 'disassemble/rs _ZN7hnswlibL20InnerProductDistanceEPKvS1_S1_' ./example_searchRan
python -m unittest discover --start-directory tests/python --pattern "bindings_test*.py"Before fix (but with example_search.cpp copied over):
After fix (note decreased time for ip):