Skip to content

test: set dontInstall - #484

Open
jmbaur wants to merge 1 commit into
nix-community:masterfrom
jmbaur:test-build-command
Open

jmbaur wants to merge 1 commit into
nix-community:masterfrom
jmbaur:test-build-command

Conversation

@jmbaur

@jmbaur jmbaur commented Jun 1, 2026 •

Copy link
Copy Markdown

Using buildPhase means that stdenvNoCC.mkDerivation still runs the other default phases, which in the default mode of operation can fail if a Makefile happens to exist in the directory the tests are ran from. Since we are only interested in running the tests with rustc, we can set dontInstall to true to prevent potential Makefile usage.

@jmbaur
jmbaur force-pushed the test-build-command branch from f175e4e to 6cc3b49 Compare June 1, 2026 17:29
@jmbaur jmbaur changed the title test: use buildCommand test: set dontInstall Jun 1, 2026
@jmbaur
jmbaur force-pushed the test-build-command branch from 6cc3b49 to 3de332b Compare June 1, 2026 18:42
@jmbaur

jmbaur commented Jun 13, 2026

Copy link
Copy Markdown
Author

cc @P-E-Meunier I saw you had made the last edits around this file

@jmbaur
jmbaur force-pushed the test-build-command branch from 3de332b to 398612d Compare July 19, 2026 19:15
@jmbaur

jmbaur commented Oct 6, 2026

Copy link
Copy Markdown
Author

Or maybe @domenkozar? :)

Using `buildPhase` means that `stdenvNoCC.mkDerivation` still runs the
other default phases, which in the default mode of operation can fail
if a Makefile happens to exist in the directory the tests are ran
from. Since we are only interested in running the tests with rustc, we
can set `dontInstall` to true to prevent potential Makefile usage.
@jmbaur
jmbaur force-pushed the test-build-command branch from 398612d to 6479798 Compare October 6, 2026 01:05

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant