Repository navigation
chore(rust): raise rust-version to 1.88, what the dependencies already need - #17
Merged
Merged
Conversation
…y need rust-version said 1.85, but the locked dependencies need 1.88 (darling 0.23, time 0.3.47, plist 1.9, serde_with 3.19), so 1.85 could not build BIDSvue anyway. CI only builds on latest stable, so nothing caught it. `cargo +1.88 check --workspace --all-targets` is clean. The datalad-rs submodule keeps its own pin. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
src-tauri/Cargo.tomlsaysrust-version = "1.85", but BIDSvue hasn't built on 1.85 for a while. On 1.85,cargo checkstops before compiling anything:The highest
rust-versionamong the locked dependencies is 1.88:darling0.23,time0.3.47,plist1.9 andserde_with3.19. Every CI job installs the latest stable Rust, so nothing noticed the gap.Change
rust-version = "1.88", with the comment updated to say where the number comes from.Cargo.lockis unchanged. Thedatalad-rssubmodule keeps its own pin (1.85); changing it is a separate change in that repo.Note:
AtomicU64::try_updateis still unstable in 1.88, so #16's compare-exchange loop remains the right fix for thefetch_updatedeprecation. The two PRs are independent.Test
cargo +1.88 check --workspace --all-targets: clean, no warnings.cargo +1.87 check: refused withbidsvue requires rustc 1.88, as intended.🤖 Generated with Claude Code