Add Ok fv attribute ignores to angular eslint#196
Draft
rajsite wants to merge 3 commits into
Draft
Conversation
Member
rajsite
commented
May 11, 2026
rajsite
commented
- Added a list of attribute ignores for ok fv components, see Nimble eslint fv ignore attributes nimble#2954
- Update CODEOWNERS to copy the pattern in nimble for fv ownership
rajsite
commented
May 11, 2026
| @@ -5,3 +5,9 @@ | |||
|
|
|||
Member
Author
There was a problem hiding this comment.
Started some offline discussion with @jattasNI if we want to track this in styleguide packages.
Member
Author
There was a problem hiding this comment.
Related, we should probably have the selectors be narrowly scoped, i.e. ok-fv-card[interaction-mode]
Member
Author
There was a problem hiding this comment.
brainstorming, other potential locations could be an @ni-labs package in this repo or in a separate repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.