Skip to content

Add default renderers for html nodes pointing at the README - #70

Merged
borkdude merged 1 commit into
mainfrom
html-renderer-hint
Jul 29, 2026
Merged

Add default renderers for html nodes pointing at the README#70
borkdude merged 1 commit into
mainfrom
html-renderer-hint

Conversation

@borkdude

Copy link
Copy Markdown
Contributor

Addresses #69.

Parsing was already CommonMark compliant. <del>\n\n*foo*\n\n</del> (https://spec.commonmark.org/0.30/#example-167) parses to html-block, paragraph, html-block, and the <aside> case in the issue matches what markdown-it produces. What made HTML look broken is that default-hiccup-renderers had no entry for :html-block and :html-inline, so ->hiccup fell through to the generic "Unknown type" span.

  • Default renderers for :html-block and :html-inline that say there is no default renderer and link to the README section.
  • README: fix the :html typo, and document that an HTML block ends at the first blank line.
  • Tests for the new message and for example 167.
  • Drop a duplicated pair of html_inline / html_block defmethods in impl.cljs.

Rendering raw HTML by default is still not the behaviour, since that means unescaped passthrough.

@borkdude

Copy link
Copy Markdown
Contributor Author

@zampino This looks like a reasonable thing to want so we don't get issues reported anymore like #69 - WDYT?

@zampino

zampino commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

@zampino This looks like a reasonable thing to want so we don't get issues reported anymore like #69 - WDYT?

sounds good

@borkdude
borkdude merged commit f632f8b into main Jul 29, 2026
7 checks passed
@borkdude
borkdude deleted the html-renderer-hint branch July 29, 2026 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants