Repository navigation
fix license - #1
Merged
Merged
Conversation
Sam-Sims
force-pushed
the
fix/license
branch
from
September 19, 2026 08:44
3371110 to
8af985d
Compare
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
Member
|
@Sam-Sims do we need to include Cris and/or Damon in the MIT notice? I couldn't tell from the git history whether you derived from their work or started fresh It looks like Cris' repo has a MIT license while Damon's repo has no license |
Contributor
Author
|
My original repo didn't include any other MIT licensed code and was written from the ground up, so from a licensing perspective I believe that is okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hey thanks for the new repo + working to get this published on Zed.
The license change in 6593253 also removed the original MIT notice. This PR restores the MIT notice in
THIRD_PARTY_LICENSESand references it from the source file alongside the Apache notice, keeping the project in line with the MIT license terms.Thanks again!