Take over id3parser package and update it#14974
Merged
Merged
Conversation
ChristophWurst
added
3. to review
Contributor
|
https://packagist.org/packages/wapmorgan/mp3info looks interesting. They claim to be faster than id3. Maybe something for Nextcloud 18. |
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
force-pushed
the
fix/id3parser-maintainer-update
branch
from
a2e4ad8 to
65dc06e
Compare
rullzer
approved these changes
Apr 12, 2019
Member
|
@kesselb I'm even fine if you want to look into that for NC17. The thing here was more that the old pakage was abandond 😉 |
Contributor
Does not support apic yet 🙈 |
MorrisJobke
approved these changes
Apr 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.