#7542:show creator and created date in respective card by samin-z · Pull Request #7650 · nextcloud/deck

samin-z · 2026-02-16T14:05:24Z

Resolves: #7542
Target version: main

Summary

Show more info regarding card like creator and date the card was created

TODO

Checklist

Code is properly formatted
Sign-off message is added to all commits
Tests (unit, integration, api and/or acceptance) are included
Documentation (manuals or wiki) has been updated or is not required

samin-z · 2026-02-16T14:16:30Z

@grnd-alt @elzody
hey, i added these info that user requested, but not sure if we should go over a design first or can just add them. any suggestions are greatly welcomed.

grnd-alt

I am not sure we want to add this feature tbh. The information is already accessible, the creation date of the card is always displayed in the card details and the creator can be found out through the activity tab. I'd be open to add the created by like this:

this uses NcUserBubble from @nextcloud/vue for reference

pipeman1981 · 2026-03-05T20:29:52Z

Hej All, hi grnd-alt,
I'm really looking forward to this feature and would be completely happy if it could be realised like you suggested.
Regards,
Carsten

samin-z · 2026-03-16T12:34:24Z

@grnd-alt, ill also apply ownership point we talked about here too in this task.

github-actions · 2026-03-25T14:15:00Z

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 94753 was 93102 (+1.77%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt

works but would be nicer to use the formatting instead of the string concatenation

grnd-alt · 2026-04-02T12:35:23Z

src/components/card/CardSidebar.vue

-			return t('deck', 'Modified') + ': ' + this.relativeDate(this.currentCard.lastModified * 1000) + ' ⸱ ' + t('deck', 'Created') + ': ' + this.relativeDate(this.currentCard.createdAt * 1000)
+			let subtitle = t('deck', 'Modified') + ': ' + this.relativeDate(this.currentCard.lastModified * 1000) + ' ⸱ ' + t('deck', 'Created') + ': ' + this.relativeDate(this.currentCard.createdAt * 1000)
+			if (this.cardOwnerDisplayName) {
+				subtitle += ' ⸱ ' + t('deck', 'by') + ': ' + this.cardOwnerDisplayName


we should use formatting inside translations here so that translators can change the order like: modified this at

here's an example on how to use the formatting: https://github.com/nextcloud/server/blob/master/apps/dashboard/src/DashboardApp.vue#L229

github-actions · 2026-04-02T15:23:34Z

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 95997 was 93102 (+3.1%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt · 2026-04-14T12:33:57Z

src/components/card/CardSidebar.vue

 		},
 		subtitleTooltip() {
-			return t('deck', 'Modified') + ': ' + this.formatDate(this.currentCard.lastModified) + '\n' + t('deck', 'Created') + ': ' + this.formatDate(this.currentCard.createdAt)
+			return this.buildSubtitleTooltip()


why have this in an extra method and not just in the computed?

because of the previous comment about using proper translation formatting, i extracted the logic into separate methods for better readability, with the new changes the logic simplified enough to be moved back into the computed properties.

grnd-alt · 2026-04-14T12:34:54Z

src/components/card/CardSidebar.vue

 	},
 	methods: {
+		buildSubtitle() {
+			const modifiedDate = this.relativeDate(this.currentCard.lastModified * 1000)


I think we should remove this entire building code and just use the subname as a slot and not as a prop, that way we can use NcUserBubble to display the user with actual profile picture etc.

with <template #subname> you can render components inside the subname

grnd-alt · 2026-04-14T12:38:11Z

src/components/card/CardSidebar.vue

+			const createdDate = this.formatDate(this.currentCard.createdAt)
+			const owner = this.cardOwnerDisplayName
+			const cardMeta = {
+				generic: t('deck', '{modified}: {modifiedDate}\n{created}: {createdDate}',


these translation strings don't need to be that modular, only actual variables should be in the {}.
like
t('deck', 'Modified: {modifiedDate}', {modifiedDate: modifiedDate})
same applies for the subtitle itself.

github-actions · 2026-04-14T15:19:52Z

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96040 was 93102 (+3.15%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

github-actions · 2026-04-15T08:27:45Z

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 96004 was 93102 (+3.11%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

grnd-alt requested changes Feb 16, 2026

View reviewed changes

samin-z force-pushed the feature/7542-show-card-creator branch from 2cac2ef to 7b31377 Compare March 25, 2026 13:51

samin-z marked this pull request as ready for review March 25, 2026 14:46

samin-z requested review from elzody and luka-nextcloud as code owners March 25, 2026 14:46

samin-z requested a review from grnd-alt March 25, 2026 14:46

samin-z added this to 📝 Productivity team Mar 25, 2026

github-project-automation bot moved this to 🧭 Planning evaluation (don't pick) in 📝 Productivity team Mar 25, 2026

samin-z moved this from 🧭 Planning evaluation (don't pick) to 👀 In review in 📝 Productivity team Mar 25, 2026

grnd-alt requested changes Apr 2, 2026

View reviewed changes

samin-z requested a review from grnd-alt April 2, 2026 15:42

grnd-alt requested changes Apr 14, 2026

View reviewed changes

samin-z requested a review from grnd-alt April 14, 2026 15:14

grnd-alt approved these changes Apr 15, 2026

View reviewed changes

samin-z added 6 commits April 15, 2026 10:22

show creator and created date in respective card

a9c3220

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

lint fix

1284be2

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

show card owner in card details

2508a4f

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

owner should not get updated when updating card

ffb1fd7

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

apply correct format

75c0589

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

use NcUserBubble

4419ca0

Signed-off-by: samin-z <samin.zavarkesh@gmail.com>

samin-z force-pushed the feature/7542-show-card-creator branch from a125c2f to 4419ca0 Compare April 15, 2026 08:22

samin-z merged commit 9b2896e into main Apr 15, 2026
43 checks passed

samin-z deleted the feature/7542-show-card-creator branch April 15, 2026 08:44

github-project-automation bot moved this from 👀 In review to ☑️ Done in 📝 Productivity team Apr 15, 2026

Conversation

samin-z commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

TODO

Checklist

Uh oh!

samin-z commented Feb 16, 2026

Uh oh!

grnd-alt left a comment

Choose a reason for hiding this comment

Uh oh!

pipeman1981 commented Mar 5, 2026

Uh oh!

samin-z commented Mar 16, 2026

Uh oh!

github-actions bot commented Mar 25, 2026

Uh oh!

grnd-alt left a comment

Choose a reason for hiding this comment

Uh oh!

grnd-alt Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

grnd-alt Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

samin-z Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

grnd-alt Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

grnd-alt Apr 14, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 14, 2026

Uh oh!

github-actions bot commented Apr 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

samin-z commented Feb 16, 2026 •

edited

Loading