TASK: Fix override of runBare() in functional test#3421
Merged
Conversation
As of PHPUnit 11 `runBare()` is a `final` method. This was written ages ago by Sebastian Kurfürst, who recently said: > IMHO we wanted to run each test twice to run it without cache and > then with cache. But it seems this was broken anyways since a long > time – so we can drop it
Member
Author
|
This is an excerpt from #3405 that fixes just the |
mhsdesign
reviewed
Jan 8, 2025
mhsdesign
left a comment
Member
There was a problem hiding this comment.
in case we consider it worth fixing we can get around this restriction of runBare and achieve the same result in a similar way.
For that we would put all generic test functions in a trait and then have two TestClasses both using this trait but having different setup methods. That way we test the same interactions with differently configured views.
Member
Author
|
Ping… |
mhsdesign
approved these changes
Jan 24, 2025
mhsdesign
left a comment
Member
There was a problem hiding this comment.
jup the StandaloneView thing override also looks kinda hacky :)
Sebobo
approved these changes
Jan 24, 2025
# Conflicts: # Neos.FluidAdaptor/Tests/Functional/View/Fixtures/View/StandaloneView.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As of PHPUnit 11
runBare()is afinalmethod.This was written ages ago by Sebastian Kurfürst, who recently said:
Checklist
FEATURE|TASK|BUGFIXReviewer - Breaking Changes are marked with!!!and have upgrade-instructions