Skip to content

Implement SnapshotJournal#hasOngoingTransaction and tests for it#3173

Open
DBotThePony wants to merge 1 commit into
neoforged:26.1.xfrom
DBotThePony:feat/enhanced-snapshot-journal
Open

Implement SnapshotJournal#hasOngoingTransaction and tests for it#3173
DBotThePony wants to merge 1 commit into
neoforged:26.1.xfrom
DBotThePony:feat/enhanced-snapshot-journal

Conversation

@DBotThePony

Copy link
Copy Markdown
Contributor

This property allows to determine whenever snapshot journal is part of any ongoing transaction, to make alternative coding pattern (properties with callbacks) viable, instead of making SnapshotJournal hard dependency everywhere it is used (locking any observers/callbacks behind journal's onRootCommit callback)

Examples of use (emulated on current journal):
DfbE3rnQIm
CdKQyNyJbQ
0EvodjoiQQ

@neoforged-automation neoforged-automation Bot added the 26.1 Targeted at Minecraft 26.1 label May 15, 2026
@neoforged-pr-publishing

Copy link
Copy Markdown
  • Publish PR to GitHub Packages

@sciwhiz12 sciwhiz12 added the enhancement New (or improvement to existing) feature or request label May 15, 2026
@Technici4n Technici4n self-assigned this May 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.1 Targeted at Minecraft 26.1 enhancement New (or improvement to existing) feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants