Skip to content

Add dependency module for install dependencies - #4305

Draft
chemzqm wants to merge 13 commits into
masterfrom
deps
Draft

Add dependency module for install dependencies#4305
chemzqm wants to merge 13 commits into
masterfrom
deps

Conversation

@chemzqm

@chemzqm chemzqm commented Oct 19, 2022

Copy link
Copy Markdown
Member

No need for npm or yarn for install dependencies of extensions.

  • Cache the downloaded tar files and resovled dependencies to improve the performance.
  • Get the best registry by use Ping when registry not specified in .npmrc
  • Cancel install process when install window close.
  • Choose cancel action by press <tab> in install window.

The missing part:

  • Install optional dependencies, need check os and cpu
  • Symbol link local file dependencies, like v12_language_service:file:v12_language_service
  • Install dependencies from github like github:discordjs/RPC, samjakob/discordjs-rp
  • Install dependencies from git url like git+https://github.com/glayzzle/php-parser.git#27abcb2337ac6450c068ef064982dfabf77916a5

@chemzqm chemzqm changed the title feat(extension): add dependency module Add dependency module for install dependencies Oct 19, 2022
@codecov

codecov Bot commented Oct 19, 2022

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.27778% with 42 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.68%. Comparing base (e650064) to head (39b10c2).
⚠️ Report is 1162 commits behind head on master.

Files with missing lines Patch % Lines
src/extension/dependency.ts 92.88% 12 Missing and 5 partials ⚠️
src/extension/ui.ts 42.10% 11 Missing ⚠️
src/extension/index.ts 88.70% 6 Missing and 1 partial ⚠️
src/extension/installer.ts 91.42% 2 Missing and 1 partial ⚠️
src/util/ping.ts 96.36% 0 Missing and 2 partials ⚠️
src/model/download.ts 90.00% 0 Missing and 1 partial ⚠️
src/util/index.ts 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4305      +/-   ##
==========================================
+ Coverage   91.66%   91.68%   +0.01%     
==========================================
  Files         262      264       +2     
  Lines       24880    25178     +298     
  Branches     5437     5494      +57     
==========================================
+ Hits        22807    23084     +277     
- Misses        874      894      +20     
- Partials     1199     1200       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chemzqm
chemzqm force-pushed the deps branch 3 times, most recently from d79f22c to 4e95818 Compare October 20, 2022 12:30
@fannheyward
fannheyward marked this pull request as draft February 21, 2024 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant