Repository navigation
Conversation
…of fixture-monkey-jakarta-validation The module only uses the jakarta.validation API; the provider is looked up at runtime. Stop publishing hibernate-validator, jakarta.el and jakarta.validation-api with compile scope, and let the test projects that use the constraint annotations declare them directly. Closes naver#1350 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
github-actions
Bot
requested review from
SooKim1110,
acktsap,
benelog,
jwChung,
mhyeon-lee and
seongahjo
September 30, 2026 21:57
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1350.
fixture-monkey-jakarta-validationno longer publishes a Bean Validation implementation withcompilescope.hibernate-validatorandjakarta.elbecome test-only dependencies, andjakarta.validation-apibecomescompileOnly.(Optional): Description
fixture-monkey-jakarta-validation/build.gradle.ktshibernate-validator,jakarta.el:api→testImplementationjakarta.validation-api:api→compileOnly+testImplementationfixture-monkey-tests/doc-examples/java-examplesandfixture-monkey-tests/kotlin-testsusejakarta.validation.constraints.*directly, but only received the API transitively. They now declarejakarta.validation-api,hibernate-validatorandjakarta.elastestImplementation.Published POM of
fixture-monkey-jakarta-validation(generatePomFileForFixtureMonkeyPublication):org.hibernate.validator:hibernate-validator:7.0.5.Finaljakarta.validation:jakarta.validation-api:3.0.2org.glassfish:jakarta.el:4.0.2fixture-monkey-api,jsr305findbugs-annotations,jspecifyThis is a behaviour change for users: anyone relying on the bundled Hibernate Validator, including
fixture-monkey-starterusers, will need to add a provider. The trade-offs are listed in #1350. I'm happy to switch to a different approach (for example, keeping the provider atruntimescope) if you prefer.How Has This Been Tested?
Full clean build on
d6e285af4: everybuild/directory deleted, then./gradlew --continue --no-build-cache build(Gradle 8.5 on JDK 17, Java 8 toolchain). I deleted the directories by hand becausefixture-monkey-tests/*disables itscleantask.java-examples:compileTestJava,kotlin-tests:compileTestKotlin(package jakarta.validation.constraints does not exist)The resolved validation dependencies in the
testRuntimeClasspathofjava-examplesandkotlin-testsare identical before and after this change.Not tested: running with an external provider (for example Hibernate Validator 8 via Spring Boot), or publishing to a repository.
Is the Document updated?
Yes, the "already provided as part of the dependency" sentence in
plugins/jakarta-validation-plugin/features.mdx(en, ko) now says that a provider must be added. Versioned docs are unchanged. If you'd like, I can also add a note toget-started/adding-bean-validation.md.🤖 Generated with Claude Code