Add optional UPnP auto discovery - #10
Open
dubocr wants to merge 12 commits into
Open
Conversation
Author
|
Dear Andrei, This pull is fully backward compatible with your version and don't need any merge. Is it possible to publish it on npm allowing everybody to use it without publishing my own version on nom that will be confusing for users. Thank you in advance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've added UPnP auto discovery feature to your awesome module. This avoid providing static IP adresse which can change over the time. Also add en event emitter to allow dependents modules to track TV availability state.
Best,