Part #1029, harden workflow run expressions - #1090
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
Conversation
Move GitHub expression values out of shell run source and into step environment variables across the cFS workflows and composite actions. This prevents expression values from being parsed as shell syntax while preserving their intended use as data. Quote path, regex, container, and configuration values at shell boundaries. CodeQL setup, prep, and build inputs intentionally represent command strings, so execute those explicitly through bash with normal error and pipe-failure handling rather than interpolating them into the generated script. Validation: - audited 92 direct expression interpolations in run blocks before the change - audited 0 after the change - all modified workflow and action YAML parses successfully - no new actionlint or ShellCheck findings compared with current nasa/cFS dev - git diff --check passes AI assistance: ChatGPT was used for repository inspection, automated audit construction, implementation assistance, validation, CI diagnostics, and diff review.
sylvesterkaczmarek
marked this pull request as ready for review
August 15, 2026 20:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Replace direct GitHub expression interpolation inside shell
run:steps across the cFS workflows and composite actions with step environment variables.This keeps expression values out of generated shell source so they are treated as data rather than shell syntax. Path, regex, container, and configuration values are quoted at shell boundaries. The CodeQL
setup,prep, andmakeinputs intentionally carry command strings, so those are executed explicitly withbash -e -o pipefail -c "$INPUT_*"to preserve their existing semantics without interpolating GitHub expressions into the shell script.The change covers 15 workflow/composite-action files and reduces direct
${{ ... }}interpolation insiderun:blocks from 92 occurrences to 0.Linked Issue
Part of #1029
Areas of Expertise Touched
Author Checklist
Validation performed on the fork before submission:
run:blocks before the change and 0 aftergit diff --checkpassedUpstream GitHub Actions are currently awaiting maintainer authorization for this fork-originated pull request, so no upstream CI result is being claimed yet.
Reviewer Checklist