Spacewire module header problems

[RR-HSz]

Hi,

1. in the spw_sbn_if_struct.h file this struct definition misses semicolons and results in a syntax error:

typedef struct { char DevClass[SBN_SPW_MAX_CHAR_NAME] /* e.g. 'spw' from /sys/class */ char DevInstance[SBN_SPW_MAX_CHAR_NAME] /* e.g. 'spw0' from /dev */ } SPW_SBNEntry_t;

2. the SBN_SPW_MAX_CHAR_NAME is not found, because its header is not included (spw_sbn_if.h)
3. spw_sbn_if.h includes the non-existing header: sbn_constants.h

Thank you!

[ivanperez-keera]

Tracking this internally now.

[ivanperez-keera]

Two of these issues were already fixed in dev:

The import of sbn_constants.h was removed:

SBN/modules/protocol/spacewire/fsw/src/spw_sbn_if_struct.h

Lines 16 to 22 in 843e733

	* limitations under the License.
	************************************************************************/
	#ifndef _spw_sbn_if_struct_h_
	#define _spw_sbn_if_struct_h_
	/* Since the target implementation of the SpaceWire driver only operates point-to-point, this struct is a bit sparse

The semicolons were added:

SBN/modules/protocol/spacewire/fsw/src/spw_sbn_if_struct.h

Lines 27 to 28 in 843e733

	char DevClass[SBN_SPW_MAX_CHAR_NAME]; /* e.g. 'spw' from /sys/class */
	char DevInstance[SBN_SPW_MAX_CHAR_NAME]; /* e.g. 'spw0' from /dev */

[ivanperez-keera]

Correction: the import of sbn_constants.h was removed from spw_sbn_if_struct.h but not from spw_sbn_if.c. It still needs to be fixed there.