Skip to content

Fix #114: remove redundant initial state check in LC_SampleAPs #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
philphauler wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix #114: remove redundant initial state check in LC_SampleAPs #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 6 additions & 27 deletions fsw/src/lc_action.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,37 +41,16 @@
void LC_SampleAPs(uint16 StartIndex, uint16 EndIndex)
{
uint16 TableIndex;
uint8 CurrentAPState;

/*
** Make sure the current state of the starting actionpoint
** in the sample is valid for a sample request
*/
CurrentAPState = LC_OperData.ARTPtr[StartIndex].CurrentState;

if ((CurrentAPState != LC_ACTION_NOT_USED) && (CurrentAPState != LC_APSTATE_PERMOFF))
** Sample selected actionpoints.
** LC_SampleSingleAP handles per-AP state checks internally,
** so no pre-check on the start index is needed.
*/
for (TableIndex = StartIndex; TableIndex <= EndIndex; TableIndex++)
{
/*
** Sample selected actionpoints
*/
for (TableIndex = StartIndex; TableIndex <= EndIndex; TableIndex++)
{
LC_SampleSingleAP(TableIndex);
}
LC_SampleSingleAP(TableIndex);
}
else
{
/*
** Actionpoint isn't currently operational
*/
CFE_EVS_SendEvent(LC_APSAMPLE_CURR_ERR_EID,
CFE_EVS_EventType_ERROR,
"Sample AP error, invalid current AP state: AP = %d, State = %d",
StartIndex,
CurrentAPState);
}

return;
}

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand Down
Loading