Fix #151, refactor HS to reduce complexity - #158
Open
jphickey wants to merge 1 commit into
Open
Conversation
Reduces the cyclic complexity of various routines. This is a substantial refactor of the code, including splitting up the "monitors" source file into subsystem-specific implementation files (app, event, exec, etc). Any function longer than ~100 lines is also split into smaller, more concise, less complex subroutines with separate documentation.
Contributor
Author
|
NOTE: This also addresses a number of inconsistencies in the file structure/patterns where HS was not following the guidelines for what goes in each of the "config" files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Reduces the cyclic complexity of various routines. This is a substantial refactor of the code, including splitting up the "monitors" source file into subsystem-specific implementation files (app, event, exec, etc).
Any function longer than ~100 lines is also split into smaller, more concise, less complex subroutines with separate documentation.
Fixes #151
Also related to #154
Testing performed
Run all tests
Manually send commands to verify FSW operation
Expected behavior changes
Better code complexity metrics, shorter files + functions
System(s) tested on
Linux
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.