Skip to content

Fix #151, refactor HS to reduce complexity - #158

Open
jphickey wants to merge 1 commit into
nasa:devfrom
jphickey:fix-151-refactor
Open

Fix #151, refactor HS to reduce complexity#158
jphickey wants to merge 1 commit into
nasa:devfrom
jphickey:fix-151-refactor

Conversation

@jphickey

Copy link
Copy Markdown
Contributor

Checklist (Please check before submitting)

Describe the contribution
Reduces the cyclic complexity of various routines. This is a substantial refactor of the code, including splitting up the "monitors" source file into subsystem-specific implementation files (app, event, exec, etc).

Any function longer than ~100 lines is also split into smaller, more concise, less complex subroutines with separate documentation.

Fixes #151
Also related to #154

Testing performed
Run all tests
Manually send commands to verify FSW operation

Expected behavior changes
Better code complexity metrics, shorter files + functions

System(s) tested on
Linux

Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.

Reduces the cyclic complexity of various routines.  This is a
substantial refactor of the code, including splitting up the "monitors"
source file into subsystem-specific implementation files (app,
event, exec, etc).

Any function longer than ~100 lines is also split into smaller, more
concise, less complex subroutines with separate documentation.
@jphickey

Copy link
Copy Markdown
Contributor Author

NOTE: This also addresses a number of inconsistencies in the file structure/patterns where HS was not following the guidelines for what goes in each of the "config" files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Functions with high cyclic complexity

2 participants