Fix #131: remove duplicate header and includes in ds_dispatch.c - #161
Open
philphauler wants to merge 1 commit into
Open
Fix #131: remove duplicate header and includes in ds_dispatch.c#161philphauler wants to merge 1 commit into
philphauler wants to merge 1 commit into
Conversation
Author
|
Pure cleanup — removes a duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the duplicate copyright header and
#includeblock inds_dispatch.c.Problem
ds_dispatch.ccontains two consecutive copyright headers and two sets of#includedirectives. The first block (lines 1-38) is the current Dracoheader with the correct includes for the dispatch module. The second block
(lines 40-78) is an older DS v2.6.1 header with includes from what was
previously
ds_cmds.c, likely left behind during a refactor.The duplicate
#include <stdio.h>and duplicate#include "ds_msgids.h"etc.are harmless to the compiler (include guards prevent double inclusion) but
are clearly unintended.
Fix
Delete the second block (39 lines). The first header and its includes are
preserved unchanged. Zero functional change.
Fixes #131.