Repository navigation
Reclassify NSKIP044 archive tests - #891
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the Nanvix test-skip classification around tarfile/shutil archive tests, with the goal of re-enabling cases that now pass and moving remaining failures under more specific NSKIP buckets.
Changes:
- Reclassifies timestamp-dependent tarfile extraction assertions from NSKIP044 to NSKIP034.
- Reclassifies the tarfile hardlink-member case from NSKIP044 to NSKIP024.
- Removes NSKIP044 skips to re-enable previously skipped tarfile/shutil archive tests on Nanvix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Lib/test/test_tarfile.py | Reclassifies Nanvix skips (NSKIP034/NSKIP024) and re-enables previously NSKIP044-skipped tarfile tests. |
| Lib/test/test_shutil.py | Re-enables archive creation/unpack tests by removing NSKIP044 skips. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+727
to
+729
| # NSKIP034 https://github.com/nanvix/cpython/issues/514 | ||
| @unittest.skipIf(support.is_nanvix, | ||
| "NSKIP044: tarfile/archive workflow corruption on Nanvix VFS") # detail: extractall via pathlike name | ||
| "NSKIP034: os.utime(times) does not modify mtime/atime on FAT VFS") # detail: extractall via pathlike name |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #524.
Closes nanvix/nanvix#3065
Summary
Testing
test_genericpathandtest_pathlibon Nanvix dev