test: complete sub-workspace duplicate-task test (#416) - #700
Merged
Conversation
Implement the deferred errors.test.ts case: registering the same task name twice inside a sub-workspace throws 'Task <name> already registered in workspace <id>', mirroring the existing root-workspace case. The other two #416 todos turned out to be features/decisions rather than unskippable tests, and are split out: alias-config validation does not exist yet (#698) and single-package-monorepo detection needs a behavior decision (#699). Their todo comments now point at those issues. Also fix a perfectionist lint error in docs/sidebars.ts (type before label) left over from the migration-guides PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
✅ Deploy Preview for nadle ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
nam-hle
enabled auto-merge (squash)
June 20, 2026 02:06
This was referenced Jun 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works #416. That issue's checklist had drifted — 3 of its 5 named files (
log-level.test.ts,exclude.test.ts,profiling-summary.test.ts) no longer exist, and 2 of the 3 remainingit.todos are actually features/decisions, not unskippable tests.What this PR does
errors.test.ts— registering the same task name twice inside a sub-workspace throwsTask <name> already registered in workspace packages:one, mirroring the existing root-workspace case.createAliasResolverdoes no semantic checks;assertAliasonly checks shape).perfectionist/sort-objectslint error indocs/sidebars.ts(type before label) left over from the migration-guides PR docs: migration guides from npm scripts, Turborepo, Nx, Makefile #696.Verification
vitest run --project nadle errors→ 3 passed (incl. the new case).nadle checkpasses.Once #698 and #699 land, their deferred
it.todos can be implemented and #416 fully closed.🤖 Generated with Claude Code