fix: resolve clearance graph importer from the declaration, not the caller - #39
Open
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
Co-Authored-By: Patrick Munis <pmunis@gmail.com>
Author
Original prompt from Patrick
|
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
regulatory.clearanceGraphpreviewed obligations for the caller, while the release gate evaluates them for the declaration's principal, so the two disagreed for anyone filing on behalf of someone else:An agent filing for a principal, or an officer previewing a declaration, never matched the principal's permit, so the graph reported blocking obligations on a consignment that release would (correctly) let through.
The graph now resolves the identity the same way the gate does when a
declarationIdis supplied, and authorises the caller with the patternallocateQuotaalready uses in the same file:Without a
declarationIdit stays a hypothetical preview keyed on the caller. No client-supplied importer identity was added — that would let any caller enumerate another party's permit position.server/regulatory.graph-importer.test.tspins the invariant against Postgres: principal, authorised agent and customs-officer previews all report the principal's permit as satisfying and agree withassertDeclarationFormalitiesSatisfied, and an unrelated third party getsFORBIDDEN.Typecheck is at the repo's standing 72-diagnostic baseline with none in the changed files; the regulatory vitest files pass (10 tests). Based on
devin/nsw-parity-registrationsbecause #33 → #35 are still open and carry the regulatory layer.Link to Devin session: https://app.devin.ai/sessions/e68f0a7bf0e04fb8a3ba32ddb8e1fa23
Requested by: @munisp