♻️ Directly pass the LLVM installation directory to cpp-linter - #448
Open
simon1hofmann wants to merge 4 commits into
Open
♻️ Directly pass the LLVM installation directory to cpp-linter#448simon1hofmann wants to merge 4 commits into
simon1hofmann wants to merge 4 commits into
Conversation
Use the workflow-installed toolchain for versions newer than the cpp-linter action supports while preserving the existing behavior for older versions. Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
simon1hofmann
marked this pull request as ready for review
September 2, 2026 13:24
denialhaag
reviewed
Sep 2, 2026
denialhaag
left a comment
Member
There was a problem hiding this comment.
As discussed on Discord, this generally LGTM! We can use this to see what the linter says! 🙂
denialhaag
approved these changes
Sep 2, 2026
Assisted-by: GPT-5.6 Sol via Codex
burgholzer
approved these changes
Sep 2, 2026
burgholzer
left a comment
Member
There was a problem hiding this comment.
Based on the offline discussion.
LGTM after addressing the two comments.
12 tasks
Assisted-by: GPT-5.6 Sol via Codex
Contributor
|
Important Approval pendingCodeRabbit has no unresolved comments, but it has not reviewed the latest commit. Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Description
Directly pass the LLVM installation directory prepared by
reusable-cpp-linter.ymltocpp-linter.The workflow already installs the requested Clang, clang-format, clang-tidy, and clang-tools packages before invoking
cpp-linter-action. Pointing the action at/usr/lib/llvm-<version>/binmakes that installed toolchain authoritative and allows callers to select Clang 23 without adding version-specific workflow logic or changing the existing input and default.This also bypasses the numeric-version limit in
cpp-linter-actionv2.21.0's bundledclang-tools1.2.0 resolver. That limit caused the jeff-mlir failure after LLVM 23 itself had installed successfully.AI assistance: GPT-5.6 Sol via Codex helped inspect the shared consumers, implement the change, and validate it.
Validation
uvx prek run -agit diff --checkllvm.sh 23installed Clang 23.1.1, clang-format 23.1.1, and clang-tidy 23.1.1 under/usr/lib/llvm-23/binChecklist
I have added appropriate tests that cover the new/changed functionality.I have updated the documentation to reflect these changes.I have added migration instructions to the upgrade guide (if needed).If PR contains AI-assisted content:
🤖 *AI text below* 🤖(titles are exempt).