Skip to content

♻️ Directly pass the LLVM installation directory to cpp-linter - #448

Open
simon1hofmann wants to merge 4 commits into
mainfrom
codex/support-clang-23
Open

♻️ Directly pass the LLVM installation directory to cpp-linter#448
simon1hofmann wants to merge 4 commits into
mainfrom
codex/support-clang-23

Conversation

@simon1hofmann

@simon1hofmann simon1hofmann commented Sep 2, 2026

Copy link
Copy Markdown

🤖 AI text below 🤖

Description

Directly pass the LLVM installation directory prepared by reusable-cpp-linter.yml to cpp-linter.

The workflow already installs the requested Clang, clang-format, clang-tidy, and clang-tools packages before invoking cpp-linter-action. Pointing the action at /usr/lib/llvm-<version>/bin makes that installed toolchain authoritative and allows callers to select Clang 23 without adding version-specific workflow logic or changing the existing input and default.

This also bypasses the numeric-version limit in cpp-linter-action v2.21.0's bundled clang-tools 1.2.0 resolver. That limit caused the jeff-mlir failure after LLVM 23 itself had installed successfully.

AI assistance: GPT-5.6 Sol via Codex helped inspect the shared consumers, implement the change, and validate it.

Validation

  • uvx prek run -a
  • git diff --check
  • Ubuntu 24.04 amd64 container: llvm.sh 23 installed Clang 23.1.1, clang-format 23.1.1, and clang-tidy 23.1.1 under /usr/lib/llvm-23/bin
  • MQT Core full-tree canary: ⬆️ Update clang-tidy to version 23 core#2328 (pending)

Checklist

  • The pull request only contains commits that are focused and relevant to this change.
  • I have added appropriate tests that cover the new/changed functionality.
  • I have updated the documentation to reflect these changes.
  • I have added entries to the changelog for any noteworthy additions, changes, fixes, or removals.
  • I have added migration instructions to the upgrade guide (if needed).
  • The changes follow the project's style guidelines and introduce no new warnings.
  • The changes are fully tested and pass the CI checks.
  • I have reviewed my own code changes.

If PR contains AI-assisted content:

  • Any agent that created, edited, or submitted GitHub content was explicitly authorized for that scope, as required by our AI Usage Guidelines.
  • Every agent-authored or agent-edited public text body begins with the visible disclosure 🤖 *AI text below* 🤖 (titles are exempt).
  • I have disclosed AI assistance in the PR description.
  • I confirm that I have personally reviewed and understood all AI-generated content, and accept full responsibility for it.

Use the workflow-installed toolchain for versions newer than the cpp-linter action supports while preserving the existing behavior for older versions.

Assisted-by: GPT-5.6 Sol via Codex
Assisted-by: GPT-5.6 Sol via Codex
@simon1hofmann simon1hofmann added fix Fix for something that is not working c++ Anything related to C++ code continuous integration Anything related to the CI setup labels Sep 2, 2026
@simon1hofmann
simon1hofmann marked this pull request as ready for review September 2, 2026 13:24

@denialhaag denialhaag left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed on Discord, this generally LGTM! We can use this to see what the linter says! 🙂

Assisted-by: GPT-5.6 Sol via Codex

@burgholzer burgholzer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the offline discussion.
LGTM after addressing the two comments.

Comment thread .github/workflows/reusable-cpp-linter.yml Outdated
Comment thread CHANGELOG.md Outdated
Assisted-by: GPT-5.6 Sol via Codex
@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Important

Approval pending

CodeRabbit has no unresolved comments, but it has not reviewed the latest commit.

Use the checkbox below to review the latest commit. CodeRabbit will approve the changes if it finds no blocking issues.

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@simon1hofmann simon1hofmann changed the title 🐛 Support Clang 23 in the reusable C++ linter ♻️ Directly pass the LLVM installation directory to cpp-linter Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Anything related to C++ code continuous integration Anything related to the CI setup fix Fix for something that is not working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants